Vishwanath Sripathy <vishwanath.bs@xxxxxx> writes: > Kevin, > >> -----Original Message----- >> From: Kevin Hilman [mailto:khilman@xxxxxx] >> Sent: Wednesday, March 02, 2011 2:32 AM >> To: Vishwanath BS >> Cc: linux-omap@xxxxxxxxxxxxxxx; patches@xxxxxxxxxx >> Subject: Re: [PATCH 1/3] OMAP3 PM: Deny clock gating only for safe >> state >> >> Vishwanath BS <vishwanath.bs@xxxxxx> writes: >> >> > Currently clock gating for MPU and core are denied whenever C1 state >> is >> > selected. >> >> Yes, that is the definition of C1. >> >> > It should be denied only when safe state is selected. >> >> Why? > Clock gating in C1 will reduce overall power consumption and it should not > impact any functionality as well. Clock gating changes latencies. >> >> This changes the definition and behavior of C1 depending on how it is >> entered. Not a good idea IMO. > I thought of adding a new C state, keeping C1 definition unchanged. Then > we will not get the real power benefit since in case of C1, clock gating > will be prevented. Let me know if you have some suggestion. My problem with this patch is that you make C1 have different behavior depending on whether it is selected directly by the governor or it is entered due to the safe state. The motiviation for this change is not at all described in the changelog. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
