Hi Kevin,
On Wed, Mar 2, 2011 at 4:03 AM, Kevin Hilman <khilman@xxxxxx> wrote:
> Lesly A M <leslyam@xxxxxx> writes:
>
>> Since the function to populate the sleep script is getting called always
>> irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data
>> is getting over written by the sleep script. Adding the missing brackets for
>> if statement to fix the issue.
>
> This is still a confusing changelog. How about simply:
>
> Only write the sleep script when TWL4030_SLEEP_SCRIPT is set.
>
Yes, I agree
Only configure sleep script when the flag is TWL4030_SLEEP_SCRIPT.
Regards,
Lesly A M
< ... >
>> if (err)
>> goto out;
>> }
>> - if (tscript->flags & TWL4030_SLEEP_SCRIPT)
>> + if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
>> if (order)
>> pr_warning("TWL4030: Bad order of scripts (sleep "\
>> "script before wakeup) Leads to boot"\
>> "failure on some boards\n");
>> err = twl4030_config_sleep_sequence(address);
>> + }
>> out:
>> return err;
>> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
