Lesly A M <leslyam@xxxxxx> writes:
> Since the function to populate the sleep script is getting called always
> irrespective of the flag "TWL4030_SLEEP_SCRIPT", other scripts data
> is getting over written by the sleep script. Adding the missing brackets for
> if statement to fix the issue.
This is still a confusing changelog. How about simply:
Only write the sleep script when TWL4030_SLEEP_SCRIPT is set.
Kevin
> Signed-off-by: Lesly A M <leslyam@xxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> Cc: David Derrick <dderrick@xxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> ---
> drivers/mfd/twl4030-power.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 16422de..2c0d4d1 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -447,12 +447,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript,
> if (err)
> goto out;
> }
> - if (tscript->flags & TWL4030_SLEEP_SCRIPT)
> + if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> if (order)
> pr_warning("TWL4030: Bad order of scripts (sleep "\
> "script before wakeup) Leads to boot"\
> "failure on some boards\n");
> err = twl4030_config_sleep_sequence(address);
> + }
> out:
> return err;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
