Hi, On Mon, Feb 28, 2011 at 12:57 PM, archit taneja <archit@xxxxxx> wrote: > Hi, > > On Monday 28 February 2011 12:49 PM, Valkeinen, Tomi wrote: >> >> On Mon, 2011-02-28 at 01:09 -0600, Taneja, Archit wrote: >>> >>> Hi, >>> >>> On Monday 28 February 2011 12:23 PM, Valkeinen, Tomi wrote: >>>> <snip> >>>>> I just realized that changing the driver name will break all scripts >>>>> and >>>>> applications using omapdss sysfs files. >>>>> >>>>> How does this sound: >>>>> >>>>> Let's leave the omapdss device name as it is. It represents a "super" >>>>> device, containing the dss sysfs files and upper level dss management. >>>>> >>>>> Name the HW module platform drivers as: omapdss_dss, omapdss_venc, >>>>> omapdss_dispc, etc. This would indicate them to be clearly parts of >>>>> DSS, >>>>> and would also prevent any possible name conflict if there would happen >>>>> to be a, say, "dsi" block in some other HW component. >>>> >>>> Any comments on this? >>> >>> I also think we need to stick to the older name, "omapdss_dss" sounds a >>> bit confusing, and I think one of the previous versions had something >>> like "dss_dss" in it and it wasn't approved. Does something like >>> "omapdss_core" or "omapdss_dss_core" make sense, or is it more >>> misleading? >> >> It is confusing, but so is the hardware naming =). There is a DSS module >> inside the omap display subsystem. That's why I would like to name it >> "dss", not "core", so it's clear it refers to this DSS module. >> >> "dss_dss" looks a bit silly, but I think "omapdss_dss" is slightly >> better in the sense that it doesn't repeat the same "dss", and there is >> an "omapdss" device, which acts like "manager" for these module devices. >> But yes, I wouldn't call it perfect either. >> >> "omapdss_dss_core" is one option. But then again, TRM doesn't speak of >> "core". > > Yes, it might get misleading if someone looking at the code tries to find > "core" in the TRM, I guess we should stick to "omapdss_dss", this also > ensures a uniform matching of the platform driver names and the beginning of > register names for each HW module. Hmmm... I guess omapdss_dss seems a better name in this view; I'm ok with this way of naming - do you want me to send a patch for it, or would you update this patch itself? ~Sumit. > > Archit > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
