Re: [patch-v2.6.39 03/12] usb: musb: gadget: do not poke with gadget's list_head

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Balbi <balbi <at> ti.com> writes:
> 
> struct usb_request's list_head is supposed to be
> used only by gadget drivers, but musb is abusing
> that. Give struct musb_request its own list_head
> and prevent musb from poking into other driver's
> business.

Hi,

I think, the patch misses to fix the usage of 
"request->list" in musb_gadget_dequeue in 
musb_gadget.c.

I found out by having troubles with f_mass_storage. 
It needs musb_gadget_dequeue to work properly...

I backported the patch to android-2.6.35 kernel on a 
omap4 system and also fixed the musb_gadget_dequeue 
there so f_mass_storage seem to work at least there 
now...

Can you check this patch regarding some missing bits
please?

Thanks,
Pavol.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux