Hi Tony, >-----Original Message----- >From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] >Sent: Thursday, February 24, 2011 12:20 AM >To: sricharan >Cc: linux-omap@xxxxxxxxxxxxxxx; santosh.shilimkar@xxxxxx; paul@xxxxxxxxx >Subject: Re: [PATCH 2/5] omap4: board-4430sdp: Initialise the serial pads > >* sricharan <r.sricharan@xxxxxx> [110127 21:04]: >> Use the mux framework to initialise the serial pads. >> >> Signed-off-by: sricharan <r.sricharan@xxxxxx> >> --- >> arch/arm/mach-omap2/board-4430sdp.c | 73 >++++++++++++++++++++++++++++++++++- >> 1 files changed, 72 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach- >omap2/board-4430sdp.c >> index 1cb208b..d77f099 100644 >> --- a/arch/arm/mach-omap2/board-4430sdp.c >> +++ b/arch/arm/mach-omap2/board-4430sdp.c >> @@ -537,8 +537,79 @@ static void __init omap_sfh7741prox_init(void) >> static struct omap_board_mux board_mux[] __initdata = { >> { .reg_offset = OMAP_MUX_TERMINATOR }, >> }; >> + >> +static struct omap_device_pad serial2_pads[] __initdata = { >> + { .name = "uart2_cts.uart2_cts", >> + .enable = OMAP_PIN_INPUT_PULLUP | OMAP_MUX_MODE0, >> + .flags = OMAP_DEVICE_PAD_REMUX_IDLE, >> + .idle = OMAP_MUX_MODE7, >> + }, > >Is there need to dynamically remux uart2_cts? If so, please >describe the reason in the patch description and comments. > >Note that if there's need for dynamic remuxing, this should >be updated for just OMAP_DEVICE_PAD_REMUX to work with the >patch I posted to replace patch 1/5. > Actually there was not a need for remixing here. I added This for testing purpose.i will remove this and send a updated Patch. >Regards, > >Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html