On 2/21/2011 11:08 PM, Tony Lindgren wrote:
* Cousson, Benoit<b-cousson@xxxxxx> [110221 13:35]:
On 2/21/2011 7:22 PM, Tony Lindgren wrote:
* Cousson, Benoit<b-cousson@xxxxxx> [110218 08:49]:
---
From b2190f0d339c9d843eb5e370d0db8b7090fbcfab Mon Sep 17 00:00:00 2001
From: Benoit Cousson<b-cousson@xxxxxx>
Date: Fri, 18 Feb 2011 14:01:06 +0100
Subject: [PATCH] OMAP4: hwmod data: Add rev and dev_attr fields in McSPI
- Add a rev attribute to identify various McSPI IP version.
- Add a dev_attr structure to provide the number of chipselect
supported by the instance.
Looks like one seems to be wrapped and does not apply even after unwapping..
#$*%&!@ Thunderbird...
:) The earlier one had double spaces in the beginning of each line in
addition to the line wrapping..
...The Thunderbird wrapping option is more powerful than expected...
Here is the same one without the "enable word wrap" and attached as well just in case.
It should apply on your omap-for-linus branch at commit df7ffd3.
Thanks, I'll apply it to omap-for-linus. The omap4 hang seems to be
caused by the timer patch, the following fixes it. How do you want
to deal with fixing this issue?
I guess it is due to the early_init change?
I have some concern bypassing hwmod to handle system timer. The idea,
before the introduction of the early_init, was to use hwmod for early
initialization as well including timers. It will become a little bit
harder now :-(
I still didn't fully understand the rational behind that early_init for
timer BTW.
Meanwhile, the following will just prevent the fmwk to reset and idle
the timer during hwmod_init.
Regards,
Benoit
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -3989,6 +3989,7 @@ static struct omap_hwmod_ocp_if
*omap44xx_timer1_slaves[] = {
static struct omap_hwmod omap44xx_timer1_hwmod = {
.name = "timer1",
.class = &omap44xx_timer_1ms_hwmod_class,
+ .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
.mpu_irqs = omap44xx_timer1_irqs,
.mpu_irqs_cnt = ARRAY_SIZE(omap44xx_timer1_irqs),
.main_clk = "timer1_fck",
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
