On Mon, 2011-02-21 at 16:38 +0200, David Cohen wrote: > Currently sched.h and wait.h have circular dependency between both. > wait.h defines macros wake_up*() which use macros TASK_* defined by > sched.h. But as sched.h indirectly includes wait.h, such wait.h header > file can't include sched.h too. The side effect is when some file > includes wait.h and tries to use its wake_up*() macros, it's necessary > to include sched.h also. > This patch moves all TASK_* macros from linux/sched.h to a new header > file linux/task_state.h. This way, both sched.h and wait.h can include > task_state.h and fix the circular dependency. No need to include sched.h > anymore when wake_up*() macros are used. I think Alexey already told you what you done wrong. Also, I really don't like the task_state.h header, it assumes a lot of things it doesn't include itself and only works because its using macros and not inlines at it probably should. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html