Hi Jean, On Fri, Feb 18, 2011 at 10:57 PM, Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> wrote: > On Fri, Feb 18, 2011 at 6:08 PM, Lesly A M <leslyam@xxxxxx> wrote: >> Patch series for TWL4030 power scripts and workaround for TWL errata 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4030 power script file, which can be used by different >> OMAP3 board with the power companion chip TWL4030. >> >> Updated the changes for TWL4030 errata 27 & 28, modified the >> TWL4030 power script and voltage controller setuptime. >> Workaround for TWL4030 errata 27 & 28 is required for >> Si version less than or equal to TWL5030 ES1.1. >> >> TWL4030 script changes rebased on Kevin's PM tree in pm branch. >> >> Changes in v7: >> changes to fix Nishanth Menon's comments >> i) Added the TWL4030 Errata 27 fix >> >> split the first patch in v6 >> i) fix for twl4030 script load >> ii) correct the warning print during script loading >> >> Added new patch files >> i) pmic_info struct cleanup >> ii) changing sys_off signal polarity >> >> Updated the change logs >> >> This changes are tested on OMAP3430 & OMAP3630 SDP with off mode enabled in suspend path. >> Tested with suspend/resume script, which will test system suspend in a loop. >> Tested for more than 1000 iterations. > > Good to see the TWL scripts back in the mainline kernel! > Are the scripts compatible with the OMAP3 Beagleboard? I would like to > test the changes on that board. I have not tested on Beagleboard. I think Beagleboard is using different PM IC TPSxxxx. If its equivalent to TRITON then this script should work on it. Regards, Lesly A M > >> >> Cc: Nishanth Menon <nm@xxxxxx> >> Cc: David Derrick <dderrick@xxxxxx> >> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> >> --- >> Lesly A M (12): >> omap3: pm: Fix for the TRITON sleep/wakeup sequence >> omap3: pm: Correct the warning print during script loading >> omap3: pm: cleanup pmic_info structure >> omap3: pm: Using separate clk/volt setup_time for RET and OFF states >> omap3630: pm: Adding voltage controller data >> omap3: pm: Correcting the sys_offmode signal polarity >> omap3: pm: Re-programing the setup time based on CORE target state >> omap3: pm: TWL4030 power scripts for OMAP3 boards >> omap3: pm: TWL5030 version checking >> mfd: TWL4030: changes for TRITON Errata 27 workaround >> omap3430: Updating the board file to use TWL4030 scripts >> omap3630: Updating the board file to use TWL4030 scripts >> >> arch/arm/mach-omap2/Makefile | 12 +- >> arch/arm/mach-omap2/board-3430sdp.c | 3 +- >> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 + >> arch/arm/mach-omap2/omap_twl.c | 369 +++++++++++++++++++++++--- >> arch/arm/mach-omap2/pm34xx.c | 15 +- >> arch/arm/mach-omap2/twl4030.c | 261 ++++++++++++++++++ >> arch/arm/mach-omap2/twl4030.h | 21 ++ >> arch/arm/mach-omap2/voltage.c | 167 +++++++++--- >> arch/arm/plat-omap/include/plat/voltage.h | 49 +++- >> drivers/mfd/twl-core.c | 50 ++++ >> drivers/mfd/twl4030-power.c | 79 ++++++- >> include/linux/i2c/twl.h | 45 +++- >> 12 files changed, 961 insertions(+), 112 deletions(-) >> create mode 100644 arch/arm/mach-omap2/twl4030.c >> create mode 100644 arch/arm/mach-omap2/twl4030.h >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html