> -----Original Message----- > From: Kalliguddi, Hema > Sent: Friday, February 18, 2011 6:37 PM > To: Premi, Sanjeev; Balbi, Felipe; Tony Lindgren > Cc: Linux OMAP Mailing List; Linux ARM Kernel Mailing List; Kevin Hilman; > Cousson, Benoit; Paul Walmsley > Subject: RE: [patch-v2.6.39 5/7] AM35xx: hwmod data: Add USBOTG > > Hi Premi, > > >-----Original Message----- > >From: Premi, Sanjeev [mailto:premi@xxxxxx] > >Sent: Friday, February 18, 2011 4:59 PM > >To: Balbi, Felipe; Tony Lindgren > >Cc: Linux OMAP Mailing List; Linux ARM Kernel Mailing List; > >Kalliguddi, Hema; Kevin Hilman; Cousson, Benoit; Paul Walmsley > >Subject: RE: [patch-v2.6.39 5/7] AM35xx: hwmod data: Add USBOTG > > > >> -----Original Message----- > >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > >> owner@xxxxxxxxxxxxxxx] On Behalf Of Balbi, Felipe > >> Sent: Thursday, February 17, 2011 6:11 PM > >> To: Tony Lindgren > >> Cc: Linux OMAP Mailing List; Linux ARM Kernel Mailing List; > >Kalliguddi, > >> Hema; Kevin Hilman; Cousson, Benoit; Paul Walmsley; Balbi, Felipe > >> Subject: [patch-v2.6.39 5/7] AM35xx: hwmod data: Add USBOTG > >> > >> From: Hema HK <hemahk@xxxxxx> > >> > >> AM35xx hwmod data structures are populated for USBOTG with > >base address, > >> L3 and L4 interface clocks and IRQ. > >> > >> Signed-off-by: Hema HK <hemahk@xxxxxx> > >> Cc: Tony Lindgren <tony@xxxxxxxxxxx> > >> Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > >> Cc: Cousson, Benoit <b-cousson@xxxxxx> > >> Cc: Paul Walmsley <paul@xxxxxxxxx> > >> Signed-off-by: Felipe Balbi <balbi@xxxxxx> > >> --- > >> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 65 > >> ++++++++++++++++++++++++++++ > >> 1 files changed, 65 insertions(+), 0 deletions(-) > >> > >[snip] > >> > >> + /* usbotg for am35x */ > >> + &am35xx_usbhsotg_hwmod, > >> + > >> NULL, > > > >Felipe, Hema, > > > >This patch will break all existing OMAP35x (and I believe > >OMAP3430 - since there is no difference - unless there is > >some trick in the USB driver code). > > > > I agree that this will break the AM35x because there is no > separate CHIP_IS* defined for AM35x. > AM35x is treated as one of the version of OMAP3430. > > >I have seen similar problems with smart reflex included in > >the AM35x hwmod data. > > Unless the new CHIP_IS_* introduced for AM35x this problem will > still exists. > > I thought you are already working on this because you were > asking the questions in the list. [sp] Yes. I am working on it. Just responded to same query. > > > > >In this case accessing "unknown" registers corresponding to > >SmartReflex in _setup() causes crash. > >(http://marc.info/?l=linux-omap&m=129777408503329&w=2) > > > >I expect similar to be happening on OMAP35x with inclusion > >of am35xx_usbhsotg_hwmod. If you don't see any crash, there > >would be side-effects - and _setup() would be initializing > >non-existent OTG registers on OMAP35x. > > > This will not impact for OMAP3 as the IDCODE is different AM35x and > OMAP3, so passing the right chip version in the HWMOD database for AM35x > will avoid the hwod init incase of OMAP3. [sp] Are you saying that IDCODE is being used in HWMOD to prevent possible 'pollution' in the current implementation of am35xx_usbhsotg_hwmod? > > >Did you see any problems while testing? > > > I tested with OMAP3430SDP and OMAP3630Zoom3 and did not see > the problem. [sp] Could this be due to difference in kind of processing done in _setup() for this hwmod. OR that addresses are (possibly) overlapping/ or not used? I suggest verifying this at the earliest. > > Regards, > Hema > > >~sanjeev > > > >PS: Sending mail via webmailer. Formatting may break > > > >> }; > >> > >> -- > >> 1.7.4.rc2 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe > >linux-omap" in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
