I understand, but is there a subtle reason why are starting from an erroneous-looking -1 rather than a more natural 0 (or 1 ?). > -----Original Message----- > From: Balbi, Felipe > Sent: Friday, February 18, 2011 4:27 PM > To: Koyamangalath, Abhilash > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: watchdog pdev id set to -1 > > Hi, > > (your lines are over 80-characters, fix it) > > On Fri, Feb 18, 2011 at 04:11:11PM +0530, Koyamangalath, Abhilash wrote: > > There this boot-time message (on both omap3 and am3517 evms atleast): > > [ 1.904418] omap_device: omap_wdt.-1: new worst case activate > > latency 0: 6105 > > > > omap_init_wdt() initializes the id to -1 and then omap_device_build() > > is called with this value; this eventually calls > > platform_device_register() with a pdev having id as -1. I don't see > > any code that checks for this -1 and changes it to a non-erroneous > > value. > > > > Perhaps there is a reason I've failed to notice? Please comment. > > Else I'm planning to submit a patch which fixes this. > > That's not an error value. If you have a -1 ID, you're only telling the > kernel "this is only omap_wdt platform_device I have", which means that > it will look in sysfs as: > > /sys/devices/platform/omap_wdt/ > > if you have an ID >= 0, it will look as: > > /sys/devices/platform/omap_wdt.0/ > /sys/devices/platform/omap_wdt.1/ > /sys/devices/platform/omap_wdt.2/ > > etc, that's all. > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
