On 2/17/2011 4:26 PM, Balbi, Felipe wrote:
On Thu, Feb 17, 2011 at 04:21:47PM +0100, Cousson, Benoit wrote:
On 2/17/2011 4:18 PM, Balbi, Felipe wrote:
On Thu, Feb 17, 2011 at 05:15:27PM +0200, Felipe Balbi wrote:
On Thu, Feb 17, 2011 at 02:43:21PM +0100, Cousson, Benoit wrote:
Hi Felipe and Hema,
Sorry for this late review, but I have a couple of comments on this one.
Since I was planning to send usb hwmod data file to Tony directly
like I did for the other drivers, I can handle the update myself if
you want.
I'll change this particular patch to yours.
doesn't apply:
$ patch -p1< ~/benoit.diff
patching file arch/arm/mach-omap2/omap_hwmod_44xx_data.c
Hunk #1 succeeded at 55 with fuzz 1 (offset -7 lines).
patch: **** malformed patch at line 42: omap44xx_l4_cfg__l3_main_2 = {
could you base this off of v2.6.38-rc5 ?
This is what I was about to say.
You have a dependency with the for_2.6.39/omap4_hwmod_data branch
in git://gitorious.org/omap-pm/linux.git.
I cannot have such a dependency and if you create that I can't send a
pull request to Tony otherwise we will have conflicts later. Either you
clear up that dependency or Tony will have to manually apply the patches
I have queued. It's only 7 of them anyway, so maybe not a big deal.
I will try to rebase that one on v2.6.38-rc5 and see if it will generate
any issue during the merge with the omap4_hwmod_data series. Generally
issues appears if the data are located at the same place in the file.
Since the usb is between uart and wd_timer, that might work.
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
