On Thu, Feb 17, 2011 at 8:32 PM, Semwal, Sumit <sumit.semwal@xxxxxx> wrote: > Hi Benoit, > > One minor comment; > > On Thu, Feb 17, 2011 at 3:54 PM, Benoit Cousson <b-cousson@xxxxxx> wrote: >> Add dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods. >> In OMAP4 there are severals IPs that can be reached by differents >> interconnect paths depending of the access initiator (MPU vs. SDMA). >> In the case of the DSS, both L3 direct path and L4 CFG path can be >> used to access all the DSS IPs. The two ocp_ip already exists to support >> the two address spaces. >> >> +------------+-- L3_MAIN --+ MPU >> IP | | >> +-- L4_CFG --+ >> >> L3 main address range is specified first, since it is used by default. >> dss is also considered as an IP as dispc, rfbi, and named as dss_core. >> >> Signed-off-by: Benoit Cousson <b-cousson@xxxxxx> >> Signed-off-by: Mayuresh Janorkar <mayur@xxxxxx> >> Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx> >> Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxx> >> [b-cousson@xxxxxx: Re-organize structures to match file >> convention and remove irq entry from dss_hwmod] >> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> @@ -1,7 +1,7 @@ >> /* >> * Hardware modules present on the OMAP44xx chips >> * >> - * Copyright (C) 2009-2010 Texas Instruments, Inc. >> + * Copyright (C) 2009-2011 Texas Instruments, Inc. >> * Copyright (C) 2009-2010 Nokia Corporation >> * >> * Paul Walmsley >> @@ -43,6 +43,7 @@ >> static struct omap_hwmod omap44xx_dma_system_hwmod; >> static struct omap_hwmod omap44xx_dmm_hwmod; >> static struct omap_hwmod omap44xx_dsp_hwmod; >> +static struct omap_hwmod omap44xx_dss_hwmod; > I guess we agreed to name this dss_core - any specific reason to change it? Oh well, blame it on weary eyes - I do see that you've named the device correctly as 'dss_core', so please ignore this comment! Best regards, ~Sumit. > > Best regards, > ~Sumit. > <snip> > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
