> -----Original Message----- > From: catalin.marinas@xxxxxxxxx [mailto:catalin.marinas@xxxxxxxxx] > On Behalf Of Catalin Marinas > Sent: Wednesday, February 16, 2011 9:24 PM > To: Santosh Shilimkar > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Andrei Warkentin; Kevin > Hilman; tony@xxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way > operation can cause data corruption > > On 15 February 2011 07:14, Santosh Shilimkar > <santosh.shilimkar@xxxxxx> wrote: > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -1140,7 +1140,7 @@ config ARM_ERRATA_742231 > > > > config PL310_ERRATA_588369 > > bool "Clean & Invalidate maintenance operations do not > invalidate > > clean lines" > > - depends on CACHE_L2X0 && ARCH_OMAP4 > > + depends on CACHE_L2X0 && CACHE_PL310 > > It can just depend on CACHE_PL310 as this depends on CACHE_L2X0. > Ok. > > +config PL310_ERRATA_727915 > > + bool "Background Clean & Invalidate by Way operation can > cause > > data corruption" > > + depends on CACHE_L2X0 && CACHE_PL310 > > Same here. > > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -45,7 +45,10 @@ config ARCH_OMAP4 > > select CPU_V7 > > select ARM_GIC > > select LOCAL_TIMERS > > + select CACHE_L2X0 > > CACHE_L2X0 has a long dependency list. You could add ARCH_OMAP4 in > there or just change the other platforms to select a > HAVE_CACHE_L2X0. > Ideally we would like this option to be selectable in config just in > case you want to debug some issues. > I will add ARCH_OMAP4 under CACHE_L2X0. > > --- a/arch/arm/mach-omap2/omap4-common.c > > +++ b/arch/arm/mach-omap2/omap4-common.c > > @@ -52,6 +52,12 @@ static void omap4_l2x0_disable(void) > > omap_smc1(0x102, 0x0); > > } > > > > +static void omap4_l2x0_set_debug(unsigned long val) > > +{ > > + /* Program PL310 L2 Cache controller debug register */ > > + omap_smc1(0x100, val); > > +} > > This part together with the Kconfig changes for OMAP4 could be a > separate patch, OMAP-specific. > Agree. I will split this patch and repost. > The rest seems fine. Thanks for the feedback. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
