> -----Original Message-----
> From: Hilman, Kevin
> Sent: Tuesday, February 15, 2011 10:12 PM
> To: DebBarma, Tarun Kanti
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v9 09/11 RESEND] OMAP: dmtimer: switch-over to
> platform device driver
>
> Tarun Kanti DebBarma <tarun.kanti@xxxxxx> writes:
>
> > NOTE: <<Missed code to configure timers to POSTED mode.>>
>
> FYI... for the future... just a reminder that text here shows up in the
> changelog in the permanent git history (unless manually edited by
> maintainers.)
>
> This kind of comment belongs after the '---' since it is useful for the
> reviewers/maintainers, but does not belong in the permanent history.
Sure, I will take care.
>
> Kevin
>
> > switch-over to platform device driver through following changes:
> > (a) call to dmtimer initialization routine from timer-gp.c is
> > removed (b) initiate dmtimer early initialization from
> omap2_init_common_hw
> > in io.c (c) modify plat-omap/dmtimer routines to use new register map
> and
> > platform data.
> >
> > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> > Acked-by: Cousson, Benoit <b-cousson@xxxxxx>
> > ---
> > arch/arm/mach-omap2/clock2420_data.c | 2 +-
> > arch/arm/mach-omap2/clock2430_data.c | 2 +-
> > arch/arm/mach-omap2/clock3xxx_data.c | 2 +-
> > arch/arm/mach-omap2/clock44xx_data.c | 2 +-
> > arch/arm/mach-omap2/dmtimer.c | 61 +++++
> > arch/arm/mach-omap2/dmtimer.h | 30 +++
> > arch/arm/mach-omap2/io.c | 3 +
> > arch/arm/mach-omap2/timer-gp.c | 1 -
> > arch/arm/plat-omap/dmtimer.c | 350 ++++++++--------------
> -------
> > arch/arm/plat-omap/include/plat/dmtimer.h | 5 +-
> > 10 files changed, 190 insertions(+), 268 deletions(-)
> > create mode 100644 arch/arm/mach-omap2/dmtimer.h
> >
> > diff --git a/arch/arm/mach-omap2/clock2420_data.c b/arch/arm/mach-
> omap2/clock2420_data.c
> > index ee93d3c..390d6aa 100644
> > --- a/arch/arm/mach-omap2/clock2420_data.c
> > +++ b/arch/arm/mach-omap2/clock2420_data.c
> > @@ -1801,7 +1801,7 @@ static struct omap_clk omap2420_clks[] = {
> > CLK(NULL, "virt_prcm_set", &virt_prcm_set, CK_242X),
> > /* general l4 interface ck, multi-parent functional clk */
> > CLK(NULL, "gpt1_ick", &gpt1_ick, CK_242X),
> > - CLK(NULL, "gpt1_fck", &gpt1_fck, CK_242X),
> > + CLK("omap_timer.1", "fck", &gpt1_fck, CK_242X),
> > CLK(NULL, "gpt2_ick", &gpt2_ick, CK_242X),
> > CLK("omap_timer.2", "fck", &gpt2_fck, CK_242X),
> > CLK(NULL, "gpt3_ick", &gpt3_ick, CK_242X),
> > diff --git a/arch/arm/mach-omap2/clock2430_data.c b/arch/arm/mach-
> omap2/clock2430_data.c
> > index 24553ce..7a3e5a4 100644
> > --- a/arch/arm/mach-omap2/clock2430_data.c
> > +++ b/arch/arm/mach-omap2/clock2430_data.c
> > @@ -1905,7 +1905,7 @@ static struct omap_clk omap2430_clks[] = {
> > CLK(NULL, "virt_prcm_set", &virt_prcm_set, CK_243X),
> > /* general l4 interface ck, multi-parent functional clk */
> > CLK(NULL, "gpt1_ick", &gpt1_ick, CK_243X),
> > - CLK(NULL, "gpt1_fck", &gpt1_fck, CK_243X),
> > + CLK("omap_timer.1", "fck", &gpt1_fck, CK_243X),
> > CLK(NULL, "gpt2_ick", &gpt2_ick, CK_243X),
> > CLK("omap_timer.2", "fck", &gpt2_fck, CK_243X),
> > CLK(NULL, "gpt3_ick", &gpt3_ick, CK_243X),
> > diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-
> omap2/clock3xxx_data.c
> > index 524d995..f318115 100644
> > --- a/arch/arm/mach-omap2/clock3xxx_data.c
> > +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> > @@ -3374,7 +3374,7 @@ static struct omap_clk omap3xxx_clks[] = {
> > CLK(NULL, "usbhost_ick", &usbhost_ick, CK_3430ES2PLUS | CK_AM35XX |
> CK_36XX),
> > CLK("ehci-omap.0", "usbhost_ick", &usbhost_ick, CK_3430ES2PLUS |
> CK_AM35XX | CK_36XX),
> > CLK(NULL, "usim_fck", &usim_fck, CK_3430ES2PLUS | CK_36XX),
> > - CLK(NULL, "gpt1_fck", &gpt1_fck, CK_3XXX),
> > + CLK("omap_timer.1", "fck", &gpt1_fck, CK_3XXX),
> > CLK(NULL, "wkup_32k_fck", &wkup_32k_fck, CK_3XXX),
> > CLK(NULL, "gpio1_dbck", &gpio1_dbck, CK_3XXX),
> > CLK("omap_wdt", "fck", &wdt2_fck, CK_3XXX),
> > diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-
> omap2/clock44xx_data.c
> > index 11997a3..8f8b010 100644
> > --- a/arch/arm/mach-omap2/clock44xx_data.c
> > +++ b/arch/arm/mach-omap2/clock44xx_data.c
> > @@ -3181,7 +3181,7 @@ static struct omap_clk omap44xx_clks[] = {
> > CLK(NULL, "smartreflex_core_fck", &smartreflex_core_fck,
> CK_443X),
> > CLK(NULL, "smartreflex_iva_fck", &smartreflex_iva_fck,
> CK_443X),
> > CLK(NULL, "smartreflex_mpu_fck", &smartreflex_mpu_fck,
> CK_443X),
> > - CLK(NULL, "gpt1_fck", &timer1_fck, CK_443X),
> > + CLK("omap_timer.1", "fck", &timer1_fck, CK_443X),
> > CLK("omap_timer.10", "fck", &timer10_fck, CK_443X),
> > CLK("omap_timer.11", "fck", &timer11_fck, CK_443X),
> > CLK("omap_timer.2", "fck", &timer2_fck, CK_443X),
> > diff --git a/arch/arm/mach-omap2/dmtimer.c b/arch/arm/mach-
> omap2/dmtimer.c
> > index 00cebe9..63d5ae7 100644
> > --- a/arch/arm/mach-omap2/dmtimer.c
> > +++ b/arch/arm/mach-omap2/dmtimer.c
> > @@ -197,3 +197,64 @@ static int __init omap_timer_init(struct omap_hwmod
> *oh, void *unused)
> >
> > return ret;
> > }
> > +
> > +/**
> > + * omap2_dm_timer_early_init - top level early timer initialization
> > + * called in the last part of omap2_init_common_hw
> > + *
> > + * Uses dedicated hwmod api to parse through hwmod database for
> > + * given class name and then build and register the timer device.
> > + * At the end driver is registered and early probe initiated.
> > + */
> > +void __init omap2_dm_timer_early_init(void)
> > +{
> > + int ret = omap_hwmod_for_each_by_class("timer",
> > + omap_timer_init, NULL);
> > +
> > + if (unlikely(ret)) {
> > + pr_err("%s: device registration failed.\n", __func__);
> > + return;
> > + }
> > +
> > + early_platform_driver_register_all("earlytimer");
> > + early_platform_driver_probe("earlytimer", early_timer_count, 0);
> > +}
> > +
> > +/**
> > + * omap2_dm_timer_normal_init - top level regular device initialization
> > + *
> > + * This initialization is done with od and pdata acquired during early
> > + * initialization. They are stored in temporary array which is cleaned
> > + * at the end of initialization.
> > + */
> > +static int __init omap2_dm_timer_normal_init(void)
> > +{
> > + int ret;
> > + struct dm_timer_data *timer_data = NULL;
> > +
> > +
> > + list_for_each_entry(timer_data, &dm_timer_data_list, node) {
> > + timer_data->pdata->is_early_init = 0;
> > + ret = platform_device_add_data(&timer_data->od->pdev,
> > + timer_data->pdata,
> > + sizeof(*timer_data->pdata));
> > + if (ret) {
> > + pr_err("%s: Failed to add platform data\n", __func__);
> > + goto next;
> > + }
> > +
> > + ret = omap_device_register(timer_data->od);
> > + if (ret)
> > + pr_err("%s: Failed to add platform device\n",
> > + __func__);
> > + else
> > + dev_dbg(&timer_data->od->pdev.dev, "%s: Registered\n",
> > + __func__);
> > +next:
> > + kfree(timer_data->pdata);
> > + kfree(timer_data);
> > + }
> > +
> > + return 0;
> > +}
> > +arch_initcall(omap2_dm_timer_normal_init);
> > diff --git a/arch/arm/mach-omap2/dmtimer.h b/arch/arm/mach-
> omap2/dmtimer.h
> > new file mode 100644
> > index 0000000..75cca6c
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/dmtimer.h
> > @@ -0,0 +1,30 @@
> > +/**
> > + * OMAP Dual-Mode Timers - early initialization interface
> > + *
> > + * Function interface called first to start dmtimer early
> initialization.
> > + *
> > + * Copyright (C) 2010 Texas Instruments Incorporated -
> http://www.ti.com/
> > + * Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
> > + * Thara Gopinath <thara@xxxxxx>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> > + * kind, whether express or implied; without even the implied warranty
> > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
> > +#ifndef __ASM_ARCH_DMTIMER_H
> > +#define __ASM_ARCH_DMTIMER_H
> > +
> > +/*
> > + * dmtimer is required during early part of boot sequence even before
> > + * device model and pm_runtime if fully up and running. This function
> > + * provides hook to omap2_init_common_hw() which is triggered from
> > + * start_kernel()->init_irq() of kernel initialization sequence.
> > + */
> > +void __init omap2_dm_timer_early_init(void);
> > +
> > +#endif
> > diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> > index 11decd8..5a7a73a 100644
> > --- a/arch/arm/mach-omap2/io.c
> > +++ b/arch/arm/mach-omap2/io.c
> > @@ -44,6 +44,7 @@
> > #include "clockdomain.h"
> > #include <plat/omap_hwmod.h>
> > #include <plat/multi.h>
> > +#include "dmtimer.h"
> >
> > /*
> > * The machine specific code may provide the extra mapping besides the
> > @@ -409,6 +410,8 @@ void __init omap2_init_common_devices(struct
> omap_sdrc_params *sdrc_cs0,
> > gpmc_init();
> >
> > omap_irq_base_init();
> > +
> > + omap2_dm_timer_early_init();
> > }
> >
> > /*
> > diff --git a/arch/arm/mach-omap2/timer-gp.c b/arch/arm/mach-omap2/timer-
> gp.c
> > index 7b7c268..2a91f2d 100644
> > --- a/arch/arm/mach-omap2/timer-gp.c
> > +++ b/arch/arm/mach-omap2/timer-gp.c
> > @@ -237,7 +237,6 @@ static void __init omap2_gp_timer_init(void)
> > BUG_ON(!twd_base);
> > }
> > #endif
> > - omap_dm_timer_init();
> >
> > omap2_gp_clockevent_init();
> > omap2_gp_clocksource_init();
> > diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> > index bfe6fd3..53f5205 100644
> > --- a/arch/arm/plat-omap/dmtimer.c
> > +++ b/arch/arm/plat-omap/dmtimer.c
> > @@ -35,20 +35,13 @@
> > * 675 Mass Ave, Cambridge, MA 02139, USA.
> > */
> >
> > -#include <linux/init.h>
> > -#include <linux/spinlock.h>
> > -#include <linux/errno.h>
> > -#include <linux/list.h>
> > #include <linux/clk.h>
> > #include <linux/delay.h>
> > #include <linux/io.h>
> > -#include <linux/module.h>
> > #include <linux/slab.h>
> > #include <linux/err.h>
> > #include <linux/platform_device.h>
> > -#include <mach/hardware.h>
> > #include <plat/dmtimer.h>
> > -#include <mach/irqs.h>
> >
> > /* register offsets */
> > #define _OMAP_TIMER_ID_OFFSET 0x00
> > @@ -159,117 +152,27 @@
> > #define OMAP_TIMER_TICK_INT_MASK_COUNT_REG \
> > (_OMAP_TIMER_TICK_INT_MASK_COUNT_OFFSET | (WP_TOWR << WPSHIFT))
> >
> > -static int dm_timer_count;
> > -
> > -#ifdef CONFIG_ARCH_OMAP2
> > -static struct omap_dm_timer omap2_dm_timers[] = {
> > - { .phys_base = 0x48028000, .irq = INT_24XX_GPTIMER1 },
> > - { .phys_base = 0x4802a000, .irq = INT_24XX_GPTIMER2 },
> > - { .phys_base = 0x48078000, .irq = INT_24XX_GPTIMER3 },
> > - { .phys_base = 0x4807a000, .irq = INT_24XX_GPTIMER4 },
> > - { .phys_base = 0x4807c000, .irq = INT_24XX_GPTIMER5 },
> > - { .phys_base = 0x4807e000, .irq = INT_24XX_GPTIMER6 },
> > - { .phys_base = 0x48080000, .irq = INT_24XX_GPTIMER7 },
> > - { .phys_base = 0x48082000, .irq = INT_24XX_GPTIMER8 },
> > - { .phys_base = 0x48084000, .irq = INT_24XX_GPTIMER9 },
> > - { .phys_base = 0x48086000, .irq = INT_24XX_GPTIMER10 },
> > - { .phys_base = 0x48088000, .irq = INT_24XX_GPTIMER11 },
> > - { .phys_base = 0x4808a000, .irq = INT_24XX_GPTIMER12 },
> > -};
> > -
> > -static const char *omap2_dm_source_names[] __initdata = {
> > - "sys_ck",
> > - "func_32k_ck",
> > - "alt_ck",
> > - NULL
> > -};
> > -
> > -static struct clk *omap2_dm_source_clocks[3];
> > -static const int omap2_dm_timer_count = ARRAY_SIZE(omap2_dm_timers);
> > -
> > -#else
> > -#define omap2_dm_timers NULL
> > -#define omap2_dm_timer_count 0
> > -#define omap2_dm_source_names NULL
> > -#define omap2_dm_source_clocks NULL
> > -#endif /* CONFIG_ARCH_OMAP2 */
> > -
> > -#ifdef CONFIG_ARCH_OMAP3
> > -static struct omap_dm_timer omap3_dm_timers[] = {
> > - { .phys_base = 0x48318000, .irq = INT_24XX_GPTIMER1 },
> > - { .phys_base = 0x49032000, .irq = INT_24XX_GPTIMER2 },
> > - { .phys_base = 0x49034000, .irq = INT_24XX_GPTIMER3 },
> > - { .phys_base = 0x49036000, .irq = INT_24XX_GPTIMER4 },
> > - { .phys_base = 0x49038000, .irq = INT_24XX_GPTIMER5 },
> > - { .phys_base = 0x4903A000, .irq = INT_24XX_GPTIMER6 },
> > - { .phys_base = 0x4903C000, .irq = INT_24XX_GPTIMER7 },
> > - { .phys_base = 0x4903E000, .irq = INT_24XX_GPTIMER8 },
> > - { .phys_base = 0x49040000, .irq = INT_24XX_GPTIMER9 },
> > - { .phys_base = 0x48086000, .irq = INT_24XX_GPTIMER10 },
> > - { .phys_base = 0x48088000, .irq = INT_24XX_GPTIMER11 },
> > - { .phys_base = 0x48304000, .irq = INT_34XX_GPT12_IRQ },
> > -};
> > -
> > -static const char *omap3_dm_source_names[] __initdata = {
> > - "sys_ck",
> > - "omap_32k_fck",
> > - NULL
> > -};
> > -
> > -static struct clk *omap3_dm_source_clocks[2];
> > -static const int omap3_dm_timer_count = ARRAY_SIZE(omap3_dm_timers);
> > -
> > -#else
> > -#define omap3_dm_timers NULL
> > -#define omap3_dm_timer_count 0
> > -#define omap3_dm_source_names NULL
> > -#define omap3_dm_source_clocks NULL
> > -#endif /* CONFIG_ARCH_OMAP3 */
> > -
> > -#ifdef CONFIG_ARCH_OMAP4
> > -static struct omap_dm_timer omap4_dm_timers[] = {
> > - { .phys_base = 0x4a318000, .irq = OMAP44XX_IRQ_GPT1 },
> > - { .phys_base = 0x48032000, .irq = OMAP44XX_IRQ_GPT2 },
> > - { .phys_base = 0x48034000, .irq = OMAP44XX_IRQ_GPT3 },
> > - { .phys_base = 0x48036000, .irq = OMAP44XX_IRQ_GPT4 },
> > - { .phys_base = 0x40138000, .irq = OMAP44XX_IRQ_GPT5 },
> > - { .phys_base = 0x4013a000, .irq = OMAP44XX_IRQ_GPT6 },
> > - { .phys_base = 0x4013a000, .irq = OMAP44XX_IRQ_GPT7 },
> > - { .phys_base = 0x4013e000, .irq = OMAP44XX_IRQ_GPT8 },
> > - { .phys_base = 0x4803e000, .irq = OMAP44XX_IRQ_GPT9 },
> > - { .phys_base = 0x48086000, .irq = OMAP44XX_IRQ_GPT10 },
> > - { .phys_base = 0x48088000, .irq = OMAP44XX_IRQ_GPT11 },
> > - { .phys_base = 0x4a320000, .irq = OMAP44XX_IRQ_GPT12 },
> > -};
> > -static const char *omap4_dm_source_names[] __initdata = {
> > - "sys_clkin_ck",
> > - "sys_32k_ck",
> > - NULL
> > -};
> > -static struct clk *omap4_dm_source_clocks[2];
> > -static const int omap4_dm_timer_count = ARRAY_SIZE(omap4_dm_timers);
> > -
> > -#else
> > -#define omap4_dm_timers NULL
> > -#define omap4_dm_timer_count 0
> > -#define omap4_dm_source_names NULL
> > -#define omap4_dm_source_clocks NULL
> > -#endif /* CONFIG_ARCH_OMAP4 */
> > -
> > -static struct omap_dm_timer *dm_timers;
> > -static const char **dm_source_names;
> > -static struct clk **dm_source_clocks;
> > -
> > static LIST_HEAD(omap_timer_list);
> > static DEFINE_SPINLOCK(dm_timer_lock);
> >
> > -/*
> > - * Reads timer registers in posted and non-posted mode. The posted mode
> bit
> > - * is encoded in reg. Note that in posted mode write pending bit must
> be
> > - * checked. Otherwise a read of a non completed write will produce an
> error.
> > +/**
> > + * omap_dm_timer_read_reg - read timer registers in posted and non-
> posted mode
> > + * @timer: timer pointer over which read operation to perform
> > + * @reg: lowest byte holds the register offset
> > + *
> > + * The posted mode bit is encoded in reg. Note that in posted mode
> write
> > + * pending bit must be checked. Otherwise a read of a non completed
> write
> > + * will produce an error.
> > */
> > static inline u32 omap_dm_timer_read_reg(struct omap_dm_timer *timer,
> u32 reg)
> > {
> > + struct dmtimer_platform_data *pdata = timer->pdev->dev.platform_data;
> > +
> > + if (reg >= OMAP_TIMER_WAKEUP_EN_REG)
> > + reg += pdata->func_offset;
> > + else if (reg >= OMAP_TIMER_STAT_REG)
> > + reg += pdata->intr_offset;
> > +
> > if (timer->posted)
> > while (readl(timer->io_base + (OMAP_TIMER_WRITE_PEND_REG &
> 0xff))
> > & (reg >> WPSHIFT))
> > @@ -277,15 +180,26 @@ static inline u32 omap_dm_timer_read_reg(struct
> omap_dm_timer *timer, u32 reg)
> > return readl(timer->io_base + (reg & 0xff));
> > }
> >
> > -/*
> > - * Writes timer registers in posted and non-posted mode. The posted
> mode bit
> > - * is encoded in reg. Note that in posted mode the write pending bit
> must be
> > - * checked. Otherwise a write on a register which has a pending write
> will be
> > - * lost.
> > +/**
> > + * omap_dm_timer_write_reg - write timer registers in posted and non-
> posted mode
> > + * @timer: timer pointer over which write operation is to perform
> > + * @reg: lowest byte holds the register offset
> > + * @value: data to write into the register
> > + *
> > + * The posted mode bit is encoded in reg. Note that in posted mode the
> write
> > + * pending bit must be checked. Otherwise a write on a register which
> has a
> > + * pending write will be lost.
> > */
> > static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32
> reg,
> > u32 value)
> > {
> > + struct dmtimer_platform_data *pdata = timer->pdev->dev.platform_data;
> > +
> > + if (reg >= OMAP_TIMER_WAKEUP_EN_REG)
> > + reg += pdata->func_offset;
> > + else if (reg >= OMAP_TIMER_STAT_REG)
> > + reg += pdata->intr_offset;
> > +
> > if (timer->posted)
> > while (readl(timer->io_base + (OMAP_TIMER_WRITE_PEND_REG &
> 0xff))
> > & (reg >> WPSHIFT))
> > @@ -293,40 +207,22 @@ static void omap_dm_timer_write_reg(struct
> omap_dm_timer *timer, u32 reg,
> > writel(value, timer->io_base + (reg & 0xff));
> > }
> >
> > -static void omap_dm_timer_wait_for_reset(struct omap_dm_timer *timer)
> > -{
> > - int c;
> > -
> > - c = 0;
> > - while (!(omap_dm_timer_read_reg(timer, OMAP_TIMER_SYS_STAT_REG) & 1))
> {
> > - c++;
> > - if (c > 100000) {
> > - printk(KERN_ERR "Timer failed to reset\n");
> > - return;
> > - }
> > - }
> > -}
> > -
> > -static void omap_dm_timer_reset(struct omap_dm_timer *timer)
> > +static void omap_dm_timer_prepare(struct omap_dm_timer *timer)
> > {
> > - u32 l;
> > + struct dmtimer_platform_data *pdata = timer->pdev->dev.platform_data;
> >
> > - if (!cpu_class_is_omap2() || timer != &dm_timers[0]) {
> > - omap_dm_timer_write_reg(timer, OMAP_TIMER_IF_CTRL_REG, 0x06);
> > - omap_dm_timer_wait_for_reset(timer);
> > + timer->fclk = clk_get(&timer->pdev->dev, "fck");
> > + if (WARN_ON_ONCE(IS_ERR_OR_NULL(timer->fclk))) {
> > + dev_err(&timer->pdev->dev, ": No fclk handle.\n");
> > + return;
> > }
> > - omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
> >
> > - l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG);
> > - l |= 0x02 << 3; /* Set to smart-idle mode */
> > - l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle */
> > + omap_dm_timer_enable(timer);
> >
> > - /*
> > - * Enable wake-up on OMAP2 CPUs.
> > - */
> > - if (cpu_class_is_omap2())
> > - l |= 1 << 2;
> > - omap_dm_timer_write_reg(timer, OMAP_TIMER_OCP_CFG_REG, l);
> > + if (pdata->dm_timer_reset)
> > + pdata->dm_timer_reset(timer);
> > +
> > + omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
> >
> > /* Match hardware reset default of posted mode */
> > omap_dm_timer_write_reg(timer, OMAP_TIMER_IF_CTRL_REG,
> > @@ -334,31 +230,26 @@ static void omap_dm_timer_reset(struct
> omap_dm_timer *timer)
> > timer->posted = 1;
> > }
> >
> > -static void omap_dm_timer_prepare(struct omap_dm_timer *timer)
> > -{
> > - omap_dm_timer_enable(timer);
> > - omap_dm_timer_reset(timer);
> > -}
> > -
> > struct omap_dm_timer *omap_dm_timer_request(void)
> > {
> > - struct omap_dm_timer *timer = NULL;
> > + struct omap_dm_timer *timer = NULL, *t;
> > unsigned long flags;
> > - int i;
> >
> > spin_lock_irqsave(&dm_timer_lock, flags);
> > - for (i = 0; i < dm_timer_count; i++) {
> > - if (dm_timers[i].reserved)
> > + list_for_each_entry(t, &omap_timer_list, node) {
> > + if (t->reserved)
> > continue;
> >
> > - timer = &dm_timers[i];
> > + timer = t;
> > timer->reserved = 1;
> > break;
> > }
> > spin_unlock_irqrestore(&dm_timer_lock, flags);
> >
> > - if (timer != NULL)
> > + if (timer)
> > omap_dm_timer_prepare(timer);
> > + else
> > + pr_debug("%s: free timer not available.\n", __func__);
> >
> > return timer;
> > }
> > @@ -366,23 +257,23 @@ EXPORT_SYMBOL_GPL(omap_dm_timer_request);
> >
> > struct omap_dm_timer *omap_dm_timer_request_specific(int id)
> > {
> > - struct omap_dm_timer *timer;
> > + struct omap_dm_timer *timer = NULL, *t;
> > unsigned long flags;
> >
> > spin_lock_irqsave(&dm_timer_lock, flags);
> > - if (id <= 0 || id > dm_timer_count || dm_timers[id-1].reserved) {
> > - spin_unlock_irqrestore(&dm_timer_lock, flags);
> > - printk("BUG: warning at %s:%d/%s(): unable to get timer %d\n",
> > - __FILE__, __LINE__, __func__, id);
> > - dump_stack();
> > - return NULL;
> > + list_for_each_entry(t, &omap_timer_list, node) {
> > + if (t->pdev->id == id && !t->reserved) {
> > + timer = t;
> > + timer->reserved = 1;
> > + break;
> > + }
> > }
> > -
> > - timer = &dm_timers[id-1];
> > - timer->reserved = 1;
> > spin_unlock_irqrestore(&dm_timer_lock, flags);
> >
> > - omap_dm_timer_prepare(timer);
> > + if (timer)
> > + omap_dm_timer_prepare(timer);
> > + else
> > + pr_debug("%s: timer%d not available.\n", __func__, id);
> >
> > return timer;
> > }
> > @@ -390,10 +281,10 @@ EXPORT_SYMBOL_GPL(omap_dm_timer_request_specific);
> >
> > void omap_dm_timer_free(struct omap_dm_timer *timer)
> > {
> > - omap_dm_timer_enable(timer);
> > - omap_dm_timer_reset(timer);
> > omap_dm_timer_disable(timer);
> >
> > + clk_put(timer->fclk);
> > +
> > WARN_ON(!timer->reserved);
> > timer->reserved = 0;
> > }
> > @@ -404,12 +295,7 @@ void omap_dm_timer_enable(struct omap_dm_timer
> *timer)
> > if (timer->enabled)
> > return;
> >
> > -#ifdef CONFIG_ARCH_OMAP2PLUS
> > - if (cpu_class_is_omap2()) {
> > - clk_enable(timer->fclk);
> > - clk_enable(timer->iclk);
> > - }
> > -#endif
> > + clk_enable(timer->fclk);
> >
> > timer->enabled = 1;
> > }
> > @@ -420,12 +306,7 @@ void omap_dm_timer_disable(struct omap_dm_timer
> *timer)
> > if (!timer->enabled)
> > return;
> >
> > -#ifdef CONFIG_ARCH_OMAP2PLUS
> > - if (cpu_class_is_omap2()) {
> > - clk_disable(timer->iclk);
> > - clk_disable(timer->fclk);
> > - }
> > -#endif
> > + clk_disable(timer->fclk);
> >
> > timer->enabled = 0;
> > }
> > @@ -445,24 +326,30 @@ EXPORT_SYMBOL_GPL(omap_dm_timer_get_irq);
> > */
> > __u32 omap_dm_timer_modify_idlect_mask(__u32 inputmask)
> > {
> > - int i;
> > + int i = 0;
> > + struct omap_dm_timer *timer = NULL;
> > + unsigned long flags;
> >
> > /* If ARMXOR cannot be idled this function call is unnecessary */
> > if (!(inputmask & (1 << 1)))
> > return inputmask;
> >
> > /* If any active timer is using ARMXOR return modified mask */
> > - for (i = 0; i < dm_timer_count; i++) {
> > + spin_lock_irqsave(&dm_timer_lock, flags);
> > + list_for_each_entry(timer, &omap_timer_list, node) {
> > +
> > u32 l;
> >
> > - l = omap_dm_timer_read_reg(&dm_timers[i], OMAP_TIMER_CTRL_REG);
> > + l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
> > if (l & OMAP_TIMER_CTRL_ST) {
> > if (((omap_readl(MOD_CONF_CTRL_1) >> (i * 2)) & 0x03) == 0)
> > inputmask &= ~(1 << 1);
> > else
> > inputmask &= ~(1 << 2);
> > }
> > + i++;
> > }
> > + spin_unlock_irqrestore(&dm_timer_lock, flags);
> >
> > return inputmask;
> > }
> > @@ -507,20 +394,22 @@ EXPORT_SYMBOL_GPL(omap_dm_timer_start);
> > void omap_dm_timer_stop(struct omap_dm_timer *timer)
> > {
> > u32 l;
> > + struct dmtimer_platform_data *pdata = timer->pdev->dev.platform_data;
> >
> > l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
> > if (l & OMAP_TIMER_CTRL_ST) {
> > l &= ~0x1;
> > omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l);
> > -#ifdef CONFIG_ARCH_OMAP2PLUS
> > - /* Readback to make sure write has completed */
> > - omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
> > - /*
> > - * Wait for functional clock period x 3.5 to make sure that
> > - * timer is stopped
> > - */
> > - udelay(3500000 / clk_get_rate(timer->fclk) + 1);
> > -#endif
> > +
> > + if (!pdata->is_omap16xx) {
> > + /* Readback to make sure write has completed */
> > + omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
> > + /*
> > + * Wait for functional clock period x 3.5 to make
> > + * sure that timer is stopped
> > + */
> > + udelay(3500000 / clk_get_rate(timer->fclk) + 1);
> > + }
> > }
> > /* Ack possibly pending interrupt */
> > omap_dm_timer_write_reg(timer, OMAP_TIMER_STAT_REG,
> > @@ -531,13 +420,15 @@ EXPORT_SYMBOL_GPL(omap_dm_timer_stop);
> > int omap_dm_timer_set_source(struct omap_dm_timer *timer, int source)
> > {
> > int ret = -EINVAL;
> > + struct dmtimer_platform_data *pdata = timer->pdev->dev.platform_data;
> >
> > if (source < 0 || source >= 3)
> > return -EINVAL;
> >
> > - clk_disable(timer->fclk);
> > - ret = clk_set_parent(timer->fclk, dm_source_clocks[source]);
> > - clk_enable(timer->fclk);
> > + omap_dm_timer_disable(timer);
> > + /* change the timer clock source */
> > + ret = pdata->set_timer_src(timer->pdev, source);
> > + omap_dm_timer_enable(timer);
> >
> > /*
> > * When the functional clock disappears, too quick writes seem
> > @@ -674,13 +565,9 @@ EXPORT_SYMBOL_GPL(omap_dm_timer_write_counter);
> >
> > int omap_dm_timers_active(void)
> > {
> > - int i;
> > -
> > - for (i = 0; i < dm_timer_count; i++) {
> > - struct omap_dm_timer *timer;
> > -
> > - timer = &dm_timers[i];
> > + struct omap_dm_timer *timer;
> >
> > + list_for_each_entry(timer, &omap_timer_list, node) {
> > if (!timer->enabled)
> > continue;
> >
> > @@ -853,58 +740,3 @@ MODULE_DESCRIPTION("OMAP Dual-Mode Timer Driver");
> > MODULE_LICENSE("GPL");
> > MODULE_ALIAS("platform:" DRIVER_NAME);
> > MODULE_AUTHOR("Texas Instruments Inc");
> > -
> > -int __init omap_dm_timer_init(void)
> > -{
> > - struct omap_dm_timer *timer;
> > - int i, map_size = SZ_8K; /* Module 4KB + L4 4KB except on omap1 */
> > -
> > - if (!cpu_class_is_omap2())
> > - return -ENODEV;
> > -
> > - spin_lock_init(&dm_timer_lock);
> > -
> > - if (cpu_is_omap24xx()) {
> > - dm_timers = omap2_dm_timers;
> > - dm_timer_count = omap2_dm_timer_count;
> > - dm_source_names = omap2_dm_source_names;
> > - dm_source_clocks = omap2_dm_source_clocks;
> > - } else if (cpu_is_omap34xx()) {
> > - dm_timers = omap3_dm_timers;
> > - dm_timer_count = omap3_dm_timer_count;
> > - dm_source_names = omap3_dm_source_names;
> > - dm_source_clocks = omap3_dm_source_clocks;
> > - } else if (cpu_is_omap44xx()) {
> > - dm_timers = omap4_dm_timers;
> > - dm_timer_count = omap4_dm_timer_count;
> > - dm_source_names = omap4_dm_source_names;
> > - dm_source_clocks = omap4_dm_source_clocks;
> > - }
> > -
> > - if (cpu_class_is_omap2())
> > - for (i = 0; dm_source_names[i] != NULL; i++)
> > - dm_source_clocks[i] = clk_get(NULL, dm_source_names[i]);
> > -
> > - if (cpu_is_omap243x())
> > - dm_timers[0].phys_base = 0x49018000;
> > -
> > - for (i = 0; i < dm_timer_count; i++) {
> > - timer = &dm_timers[i];
> > -
> > - /* Static mapping, never released */
> > - timer->io_base = ioremap(timer->phys_base, map_size);
> > - BUG_ON(!timer->io_base);
> > -
> > -#ifdef CONFIG_ARCH_OMAP2PLUS
> > - if (cpu_class_is_omap2()) {
> > - char clk_name[16];
> > - sprintf(clk_name, "gpt%d_ick", i + 1);
> > - timer->iclk = clk_get(NULL, clk_name);
> > - sprintf(clk_name, "gpt%d_fck", i + 1);
> > - timer->fclk = clk_get(NULL, clk_name);
> > - }
> > -#endif
> > - }
> > -
> > - return 0;
> > -}
> > diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-
> omap/include/plat/dmtimer.h
> > index 1a080db..15ac8a8 100644
> > --- a/arch/arm/plat-omap/include/plat/dmtimer.h
> > +++ b/arch/arm/plat-omap/include/plat/dmtimer.h
> > @@ -58,10 +58,9 @@
> > #define OMAP_TIMER_IP_VERSION_2 0x2
> >
> > struct omap_dm_timer {
> > - unsigned long phys_base;
> > int id;
> > int irq;
> > - struct clk *iclk, *fclk;
> > + struct clk *fclk;
> > void __iomem *io_base;
> > unsigned reserved:1;
> > unsigned enabled:1;
> > @@ -86,8 +85,6 @@ struct dmtimer_platform_data {
> > u32 is_omap16xx:1;
> > };
> >
> > -int omap_dm_timer_init(void);
> > -
> > struct omap_dm_timer *omap_dm_timer_request(void);
> > struct omap_dm_timer *omap_dm_timer_request_specific(int timer_id);
> > void omap_dm_timer_free(struct omap_dm_timer *timer);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
