Hi Kevin, Benoit, On Fri, Feb 11, 2011 at 5:01 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Omar Ramirez Luna <omar.ramirez@xxxxxx> writes: > >> Mailbox hwmod support for OMAP 2,3,4. >> >> This was tested on OMAP3 (3430, 3630), minor testing >> was made on OMAP4. >> >> No testing on OMAP2 since I don't have the hardware. > > To help in testing, I wrote a simple mailbox loopback test module for > OMAP2/3/4 that I used to do send and receive messages on the MPU. This > can be used to test the mailbox without any DSP software. > > I tested it against l-o master branch and found a couple bugs in the > mailbox driver (patches posted earlier today.) > > With those patches plus my test I can send & receieve a series of > messages on the MPU, which is enough to sanity test the basic sending > and receiving messages on the MPU. > > I've tested the master branch, now it's your turn to use this test > module to validate this hmod conversion series. > > The test module is available here: > > git://gitorious.org/omap-test/mailbox.git I rechecked on OMAP3 (zoom2, zoom3) and OMAP4 (blaze), and functionality hasn't changed with the hwmod support + Kevin's mbox test. On OMAP3, although functionality is ok with this patch set, I noticed that the interface clock is not being disabled with its corresponding pm_runtime_disable call. Previously, the driver enabled/disabled the ick clock on demand, but now the clock stays enabled always (only affected by the smart-idle feature, I presume). Should this clock be placed in the main_clk field of omap_hwmod struct instead of omap_hwmod_ocp_if, I moved it to ocp_if because of the ick thing, any comment? Regards, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
