>-----Original Message----- >From: ext DebBarma, Tarun Kanti [mailto:tarun.kanti@xxxxxx] >Sent: 15 February, 2011 11:31 >To: Kristo Tero (Nokia-MS/Tampere); Hilman, Kevin >Cc: linux-omap@xxxxxxxxxxxxxxx >Subject: RE: [PATCH] omap: dmtimer: Enable autoidle > >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> owner@xxxxxxxxxxxxxxx] On Behalf Of DebBarma, Tarun Kanti >> Sent: Tuesday, February 15, 2011 2:50 PM >> To: Tero.Kristo@xxxxxxxxx; Hilman, Kevin >> Cc: linux-omap@xxxxxxxxxxxxxxx >> Subject: RE: [PATCH] omap: dmtimer: Enable autoidle >> >> > -----Original Message----- >> > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> > owner@xxxxxxxxxxxxxxx] On Behalf Of Tero.Kristo@xxxxxxxxx >> > Sent: Tuesday, February 15, 2011 1:47 PM >> > To: Hilman, Kevin >> > Cc: linux-omap@xxxxxxxxxxxxxxx >> > Subject: RE: [PATCH] omap: dmtimer: Enable autoidle >> > >> > >> > >> > >-----Original Message----- >> > >From: ext Kevin Hilman [mailto:khilman@xxxxxx] >> > >Sent: 15 February, 2011 01:29 >> > >To: Kristo Tero (Nokia-MS/Tampere) >> > >Cc: linux-omap@xxxxxxxxxxxxxxx >> > >Subject: Re: [PATCH] omap: dmtimer: Enable autoidle >> > > >> > >Tero Kristo <tero.kristo@xxxxxxxxx> writes: >> > > >> > >> This will save some power. >> > >> >> > >> Signed-off-by: Tero Kristo <tero.kristo@xxxxxxxxx> >> > > >> > >Please report which platforms this was tested with. >> > >> > Tested only on OMAP3. >> > >> > Should this be changed to apply only on that one? I don't know about >> > OMAP4, but I think this should work on OMAP2 at least based on spec. >> It works on OMAP2 and OMAP4. >Ok, on OMAP4 I should have clarified further. >AUTOIDLE is present only for millisecond timers: 1,2,10. >The reset of the timers do not have this bit. Does it matter if the bit is set on the timers that don't have it or does the HW just ignore it? Or should we enumerate the timers that support it on omap4? >-- >Tarun > >> >> > >> > >> > > >> > >Also, please Cc linux-arm-kernel. >> > > >> > >Thanks, >> > > >> > >Kevin >> > > >> > >> --- >> > >> arch/arm/plat-omap/dmtimer.c | 1 + >> > >> 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> >> > >> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat- >> > >omap/dmtimer.c >> > >> index 1d706cf..949becc 100644 >> > >> --- a/arch/arm/plat-omap/dmtimer.c >> > >> +++ b/arch/arm/plat-omap/dmtimer.c >> > >> @@ -341,6 +341,7 @@ static void omap_dm_timer_reset(struct >> > >omap_dm_timer *timer) >> > >> l = omap_dm_timer_read_reg(timer, OMAP_TIMER_OCP_CFG_REG); >> > >> l |= 0x02 << 3; /* Set to smart-idle mode */ >> > >> l |= 0x2 << 8; /* Set clock activity to perserve f-clock >on >> idle >> > >*/ >> > >> + l |= 0x1 << 0; /* Set autoidle */ >> > >> >> > >> /* >> > >> * Enable wake-up on OMAP2 CPUs. >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux- >omap" in >> > the body of a message to majordomo@xxxxxxxxxxxxxxx >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" >in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
