We're almost there. retu.c looks very nice now. The bulk effort is now on its children: . retu-headset.c . should use jack framework . should use dev_pm_ops . some cleanups wouldn't hurt . retu-rtc.c . needs suspend/resume (?) . retu-wdt.c . needs suspend/resume (?) patches also available at [1] for convenience [1] git://gitorious.org/usb/usb.git cbus Felipe Balbi (15): cbus: retu: drop retu_get_status cbus: retu: replace BUG_ON with WARN cbus: retu: drop the unnecessary spinlock_t cbus: retu: drop unused PFX macro arm: omap: cbus: add IDs for Retu and Tahvo arm: omap: pass Retu ID via platform_data cbus: retu: use the devid from platform_data cbus: retu: introduce internal read/write functions cbus: retu: search and replace cbus: retu: pwrbutton: save device pointer on our structure cbus: retu: pass the child device pointer to all retu functions cbus: retu: headset: don't save pdev pointer cbus: retu: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL cbus: retu: tabify retu initialization cbus: retu: set pm_power_off to NULL when removing retu arch/arm/mach-omap1/board-nokia770.c | 1 + arch/arm/mach-omap2/board-n8x0.c | 1 + arch/arm/plat-omap/include/plat/cbus.h | 4 + drivers/cbus/retu-headset.c | 35 ++++--- drivers/cbus/retu-pwrbutton.c | 4 +- drivers/cbus/retu-rtc.c | 34 +++---- drivers/cbus/retu-wdt.c | 15 +--- drivers/cbus/retu.c | 160 +++++++++++++++++++------------- drivers/cbus/retu.h | 10 +- 9 files changed, 146 insertions(+), 118 deletions(-) -- 1.7.4.rc2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html