Hi, On Mon, Feb 14, 2011 at 01:21:31PM +0100, Laurent Pinchart wrote: > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c > index 4cf48ea..5d844bd 100644 > --- a/arch/arm/mach-omap2/devices.c > +++ b/arch/arm/mach-omap2/devices.c > @@ -38,7 +38,7 @@ > > #if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE) > > -static struct resource cam_resources[] = { > +static struct resource omap2cam_resources[] = { should this be __initdata ?? > @@ -158,6 +149,14 @@ int omap3_init_camera(void *pdata) > } > EXPORT_SYMBOL_GPL(omap3_init_camera); > > +static inline void omap_init_camera(void) why inline ? also, should this be marked __init ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html