On Mon, Feb 14, 2011 at 12:36 AM, Varadarajan, Charulatha <charu@xxxxxx> wrote: > On Sat, Feb 12, 2011 at 19:09, David Cohen <dacohen@xxxxxxxxx> wrote: >> Function declaration 'iopgtable_lookup_entry' is missing from header >> file. > > Is this done because of any error? > You may add a comment on why this is required. The function is exported by iommu module, but no other driver is using it so far. So, it's wrong but currently we have only a sparse warning. I can add this information to the patch description. Br, David > >> >> Signed-off-by: David Cohen <dacohen@xxxxxxxxx> >> --- >> Âarch/arm/plat-omap/include/plat/iommu.h | Â Â2 ++ >> Â1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h >> index 9e8c104..5a2475f 100644 >> --- a/arch/arm/plat-omap/include/plat/iommu.h >> +++ b/arch/arm/plat-omap/include/plat/iommu.h >> @@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end); >> Âextern void flush_iotlb_all(struct iommu *obj); >> >> Âextern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e); >> +extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd, >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âu32 **ppte); >> Âextern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova); >> >> Âextern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end); >> -- >> 1.7.1 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
