> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Tuesday, February 08, 2011 8:27 AM > To: rnayak@xxxxxx; Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; b-cousson@xxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support for all DPLL's > > Hi > > On Fri, 4 Feb 2011, Santosh Shilimkar wrote: > > > From: Rajendra Nayak <rnayak@xxxxxx> > > > > All OMAP3/4 dpll's support hardware level autogating. > > Populate allow_idle/deny_idle function pointers for all > > DPLL's in clkops. > > > > Also for OMAP4, call omap_clk_enable_autoidle() from PM > > core (only with CONFIG_PM) to enable hardware level > > autogating on all clock nodes which support it (For now > > only DPLL nodes) > > > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxx> > > --- > > arch/arm/mach-omap2/clock.c | 8 +++++++- > > arch/arm/mach-omap2/clock.h | 1 + > > arch/arm/mach-omap2/clock3xxx_data.c | 2 +- > > arch/arm/mach-omap2/clock44xx_data.c | 2 +- > > arch/arm/mach-omap2/pm44xx.c | 4 ++++ > > Looks like you add the allow_idle/deny_idle functions for the OMAP3 CORE > DPLL, but you don't change mach-omap2/pm34xx.c. Any reason for this? Nothing specifically. My initial patchset was enabling these only for OMAP4, So I thought will keep it that way. > It > seems that the current OMAP3 PM code doesn't enable CORE DPLL autoidle. > Do you recall why? Perhaps it is due to some of the autoidle bugs, where > DPLL3 would enter auto-idle while some OMAP3 IP blocks that used CORE > clocks were not idle... I don't recall any such bug, however I will relook at the errata docs and also do some validation around this on OMAP3 and report. Regards, Rajendra > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
