> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Tuesday, February 08, 2011 7:18 AM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; b-cousson@xxxxxx; rnayak@xxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 4/9] omap: clocks: Add checks to see if enable/disable ops are supported > > On Fri, 4 Feb 2011, Santosh Shilimkar wrote: > > > From: Rajendra Nayak <rnayak@xxxxxx> > > > > Check if enable/disable operations are supported for a given > > clock node before attempting to call them. > > > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxx> > > --- > > arch/arm/mach-omap2/clock.c | 14 +++++++++----- > > 1 files changed, 9 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c > > index 2a2f152..5c08c18 100644 > > --- a/arch/arm/mach-omap2/clock.c > > +++ b/arch/arm/mach-omap2/clock.c > > @@ -261,7 +261,8 @@ void omap2_clk_disable(struct clk *clk) > > > > pr_debug("clock: %s: disabling in hardware\n", clk->name); > > > > - clk->ops->disable(clk); > > + if (clk->ops && clk->ops->enable) > > + clk->ops->disable(clk); > > Shouldn't that read: > > if (clk->ops && clk->ops->disable) > > ? Oops.. I guess it should. Will fix that and repost. > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
