> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxx] > Sent: Thursday, February 03, 2011 2:58 AM > To: Rajendra Nayak > Cc: Santosh Shilimkar; linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; > Benoit Cousson; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/6] omap4: powerdomain: Add supported INACTIVE > power state > > Rajendra Nayak <rnayak@xxxxxx> writes: > > > Hi Kevin, > > > >> -----Original Message----- > >> From: Kevin Hilman [mailto:khilman@xxxxxx] > >> Sent: Wednesday, February 02, 2011 6:49 AM > >> To: Santosh Shilimkar > >> Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; b-cousson@xxxxxx; > > rnayak@xxxxxx; linux-arm- > >> kernel@xxxxxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH 1/6] omap4: powerdomain: Add supported > INACTIVE > > power state > >> > >> Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > >> > >> > On OMAP4, one can explicitly program INACTIVE as the power > state of > >> > the logic area inside the power domain. Techincally PD state > > programmed > >> > to ON and if all the clock domains within the PD are idled, is > > equivalent > >> > tp PD programmed to INACTIVE and all the clock domains within > the PD > > are > >> > idled. There won't be any power difference in above two. > >> > > >> > Since the CPUIDLE C-states explicitly make use of INACTIVE as a > PD > >> > targeted state > >> > >> I think you're referring to code that is not upstream here. I'm > not > >> aware of any C-states targetting INACTIVE. > > > > On OMAP3, C2/3/4 have target state as CORE inactive, while C1 is > > CORE active. > > I see what you're saying now. > > However, from a code point of view, all of those C-states are > programmed > to PWRDM_POWER_ON. > > Therefore the changelog is not accurate. Specifically the use of > "explicitly" is wrong, because the use of INACTIVE is most certainly > not explicit. > Ok. The 'explicit' came from OMAP4 where you could program it. I agree the code is not there in mainline to show this. I can drop the explicit from change log if it helps. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
