Varadarajan, Charulatha wrote: > On Wed, Feb 2, 2011 at 21:00, Sourav Poddar <sourav.poddar@xxxxxx> wrote: > > The ads7846 driver requests a gpio to detect pendown events, > > but does not configure its direction. Configure this gpio > > as an input after requesting it. > > > > NACK to this patch too for similar reasons as in patch1 of > this series. > What similar reasons? Felipe's comment about checking for a return value here is valid. But I don't see your point. The driver does a gpio_request just two lines above and does not set the direction. gpio_request does not set the direction by itself. Maybe it's not essential and the default is to have direction as input, but it's quite common to explicitly configure this. Confused, Anand -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
