Hi, On Wed, Feb 02, 2011 at 09:00:46PM +0530, Sourav Poddar wrote: > The ads7846 driver requests a gpio to detect pendown events, > but does not configure its direction. Configure this gpio > as an input after requesting it. > > Signed-off-by: Sourav Poddar <sourav.poddar@xxxxxx> > --- > drivers/input/touchscreen/ads7846.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c > index 036f245..c001ce5 100644 > --- a/drivers/input/touchscreen/ads7846.c > +++ b/drivers/input/touchscreen/ads7846.c > @@ -962,6 +962,7 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784 > return err; > } > > + gpio_direction_input(pdata->gpio_pendown); this function returns a value on error, it's better if you check it. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
