On Tue, 01 Feb 2011 14:22:49 +0200
Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> wrote:
> Looks good, but...
> > + if (oh->class->rev == MCBSP_CONFIG_TYPE3) {
> > + if (id == 2)
> > + pdata->buffer_size = 0x500; /*FIFO size is 1024 + 256*/
> > + else
> > + pdata->buffer_size = 0x80; /*FIFO size is 128*/
> > + }
>
> I would add spaces around these comments (after /* and before */).
>
Actually this part of code doesn't compile for CONFIG_ARCH_OMAP2 if
CONFIG_ARCH_OMAP3 is not set. Reason is that the buffer_size in under
CONFIG_ARCH_OMAP3 compilation in struct omap_mcbsp_platform_data
definition.
I think it's easiest if this patch just removes that conditional
compilation from struct omap_mcbsp_platform_data as it really doesn't
save that much from non !OMAP3 builds.
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
