On Tue, Jan 25, 2011 at 5:48 PM, <jean.pihet@xxxxxxxxxxxxxx> wrote:
> From: Jean Pihet <j-pihet@xxxxxx>
>
> Fix a potential problem with function types when calling the
> fncpy API to copy the PM code functions to SRAM.
>
> Signed-off-by: Jean Pihet <j-pihet@xxxxxx>
> ---
> arch/arm/plat-omap/include/plat/sram.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/sram.h b/arch/arm/plat-omap/include/plat/sram.h
> index d673f2c..f500fc3 100644
> --- a/arch/arm/plat-omap/include/plat/sram.h
> +++ b/arch/arm/plat-omap/include/plat/sram.h
> @@ -18,10 +18,10 @@ extern void *omap_sram_push_address(unsigned long size);
>
> /* Macro to push a function to the internal SRAM, using the fncpy API */
> #define omap_sram_push(funcp, size) ({ \
> - typeof(&funcp) _res = NULL; \
> + typeof(&(funcp)) _res = NULL; \
> void *_sram_address = omap_sram_push_address(size); \
> if (_sram_address) \
> - _res = fncpy(_sram_address, &funcp, size); \
> + _res = fncpy(_sram_address, &(funcp), size); \
> _res; \
> })
I believe this is sound, though I'm not yet in a position to test it fully.
When I have the OMAP kernel building with Thumb-2 again I will follow up.
Cheers
---Dave
Reviewed-by: Dave Martin <dave.martin@xxxxxxxxxx>
>
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
