Ricardo Salveti de Araujo <ricardo.salveti@xxxxxxxxxxxxx> writes:
> In case in user has a OMAP3630 < ES1.2 the kernel should warn the user
> about the ERRATUM, but using printk instead of WARN_ON is already
> enough, as there is nothing else the user can do besides changing the
> board.
I agree, it doesn't need a full backtrace.
Minor comment below...
> Signed-off-by: Ricar
do Salveti de Araujo <ricardo.salveti@xxxxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/cpuidle34xx.c | 2 +-
> arch/arm/mach-omap2/pm34xx.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
> index f7b22a1..abb9be0 100644
> --- a/arch/arm/mach-omap2/cpuidle34xx.c
> +++ b/arch/arm/mach-omap2/cpuidle34xx.c
> @@ -464,7 +464,7 @@ void omap_init_power_states(void)
> if (IS_PM34XX_ERRATUM(PM_SDRC_WAKEUP_ERRATUM_i583)) {
> omap3_power_states[OMAP3_STATE_C7].valid = 0;
> cpuidle_params_table[OMAP3_STATE_C7].valid = 0;
> - WARN_ONCE(1, "%s: core off state C7 disabled due to i583\n",
> + printk(KERN_WARNING "%s: core off state C7 disabled due to i583\n",
> __func__);
Please use pr_warn() instead.
> }
> }
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index a4aa192..983b543 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -927,7 +927,7 @@ void omap3_pm_off_mode_enable(int enable)
> pwrst->pwrdm == core_pwrdm &&
> state == PWRDM_POWER_OFF) {
> pwrst->next_state = PWRDM_POWER_RET;
> - WARN_ONCE(1,
> + printk(KERN_WARNING
> "%s: Core OFF disabled due to errata i583\n",
> __func__);
ditto
> } else {
Thanks,
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
