> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Tuesday, January 25, 2011 10:28 PM > To: Ghorai, Sukumar > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc > > * Ghorai, Sukumar <s-ghorai@xxxxxx> [110122 09:53]: > > > > > > I think I've commented on this before, but why don't you make > gpmc_init > > > a subsys_initcall? There should be no reason to call this earlier. > > > If something does not work because of that, then that issue must be > > > fixed. > > > > [Ghorai] You suggested the same in previous v5 and v6; and I mentioned > > the issues [1] that - nand_init()called before > subsys_initcall(gpmc_init); > > Let me know if I am missing anything again. > > There should not be any need to call nand_init early either. We want > to initialize as much as possible late so we have proper console > error messages. [Ghorai] thanks... changed to postcore_initcall() and it solved the problem I mentioned earlier. And it simplifies the overall modification in different board files. postcore_initcall(gpmc_init); > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
