On Tue, Jan 25, 2011 at 12:26, Hiremath, Vaibhav <hvaibhav@xxxxxx> wrote:
>
>> -----Original Message-----
>> From: Varadarajan, Charulatha
>> Sent: Tuesday, January 25, 2011 12:20 PM
>> To: Hiremath, Vaibhav
>> Cc: linux-omap@xxxxxxxxxxxxxxx; Hilman, Kevin; tony@xxxxxxxxxxx
>> Subject: Re: [PATCH] OMAP3EVM:FIX: Reset the SMSC911x Ethernet controller
>> in board_init
>>
>> <<snip>>
>>
>> Missed this one in the previous threads.
>>
>> >> > +
>> >> > eth_cs = OMAP3EVM_SMSC911X_CS;
>> >> >
>> >> > l3ck = clk_get(NULL, "l3_ck");
>> >> > @@ -136,6 +141,22 @@ static inline void __init
>> >> omap3evm_init_smsc911x(void)
>> >> > else
>> >> > rate = clk_get_rate(l3ck);
>> >> >
>> >> > + /* Configure ethernet controller reset gpio */
>> >> > + if (cpu_is_omap3430()) {
>> >>
>> >> cpu_is_omap3430() is not required, as this board init would not be
>> >> called otherwise.
>> > [Hiremath, Vaibhav] That is not quite true, why do you say this?
>>
>> The board file init means that the cpu info is already identified.
>> Do you think that omap3evm_init_smsc911x() would be called for
>> other than OMAP3430?
>>
> [Hiremath, Vaibhav] Yes, for all processors version (OMAP35x, AM/DM37x) which uses this EVM file.
Ok. Thanks for the clarification.
>
> Thanks,
> Vaibhav
>> >
>> >>
>> >> > + if (gpio_request(eth_rst, "SMSC911x gpio") < 0) {
>> >> > + pr_err(KERN_ERR "Failed to request GPIO7 for
>> >> smsc911x\n");
>> >> > + return;
>> >> > + }
>> >> > +
>> >> > + gpio_direction_output(eth_rst, 1);
>> >>
>>
>> <<snip>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
