Re: [PATCH] OMAP3EVM: Made backlight GPIO default state to off

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 24, 2011 at 20:06,  <hvaibhav@xxxxxx> wrote:
> From: Vaibhav Hiremath <hvaibhav@xxxxxx>
>
> If you choose default output to DVI, the LCD backlight stays on,
> since panel->disable function never gets called.
>
> So, during init put backlight GPIO to off state and the driver
> code will decide which output to enable.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> ---
>  arch/arm/mach-omap2/board-omap3evm.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
> index 1b8a806..3f5117a 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -448,7 +448,10 @@ static int omap3evm_twl_gpio_setup(struct device *dev,
>
>        /* TWL4030_GPIO_MAX + 0 == ledA, LCD Backlight control */
>        gpio_request(gpio + TWL4030_GPIO_MAX, "EN_LCD_BKL");

Check for the return value and then only proceed

> -       gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> +       if (get_omap3_evm_rev() >= OMAP3EVM_BOARD_GEN_2)
> +               gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);

Check for the return value

> +       else
> +               gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);

Ditto

>
>        /* gpio + 7 == DVI Enable */
>        gpio_request(gpio + 7, "EN_DVI");
> --
> 1.6.2.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux