Re: Setting MMC_CAP_POWER_OFF_CARD on mmc2 leads to filesystem problems on mmc1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 22 jan 2011, om 11:36 heeft Ohad Ben-Cohen het volgende geschreven:

> Hi Koen,
> 
> On Fri, Jan 21, 2011 at 4:49 PM, Luciano Coelho <coelho@xxxxxx> wrote:
>>> My patch basically does:
>>> 
>>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>>> @@ -270,7 +270,7 @@ static struct omap2_hsmmc_info mmc[] = {
>>>        {
>>>                .name           = "wl1271",
>>>                .mmc            = 2,
>>> -               .caps           = MMC_CAP_4_BIT_DATA,
>>> +               .caps           = MMC_CAP_4_BIT_DATA | MMC_CAP_POWER_OFF_CARD,
>>> 
>>> And does NOT touch mmc1. But after adding MMC_CAP_POWER_OFF_CARD I get tons of:
> 
> 
> Hmm. The snippet above looks different in your patch.
> 
> It seems that you're adding a new mmcbbt array, along with the
> existing mmc one, but still using unchanged board-omap3beagle code,
> and I suspect you have some unhealthy  mmc/mmcbbt references.
> 
> Particularly, look at this:
> 
> @@ -384,7 +445,14 @@ static int beagle_twl_gpio_setup(struct device *dev,
> 	}
> 	/* gpio + 0 is "mmc0_cd" (input/IRQ) */
> 	mmc[0].gpio_cd = gpio + 0;
> +#if defined(CONFIG_WL1271) || defined(CONFIG_WL1271_MODULE)
> +	if(!strcmp(expansionboard_name, "fixme-beagletoy"))
> +		omap2_hsmmc_init(mmcbbt);
> +	else
> +		omap2_hsmmc_init(mmc);
> +#else
> 	omap2_hsmmc_init(mmc);
> +#endif
> 
> 	/* link regulators to MMC adapters */
> 	beagle_vmmc1_supply.dev = mmc[0].dev;
> 
> When WL1271 is configured, and you have your "fixme-beagletoy"
> expansionboard around, you're only initializing mmcbbt, but still
> using mmc for regulators references.
> 
> Care to check if fixing that makes your issues go away ?

That was indeed the problem, not I get:

[   35.417053] wl1271: firmware booted (Rev 6.1.0.0.343)

and

root@beagleboard-xm-next:~# ifconfig wlan0 hw eth 00:11:22:33:44:55
root@beagleboard-xm-next:~# iwlist wlan0 scanning | grep ESSID | wc -l
13

That get's me a lot further!

regards,

Koen

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux