On Fri, Jan 21, 2011 at 9:37 AM, Ghorai, Sukumar <s-ghorai@xxxxxx> wrote: > >> -----Original Message----- >> From: Vimal Singh [mailto:vimal.newwork@xxxxxxxxx] >> Sent: Thursday, January 20, 2011 8:47 PM >> To: Ghorai, Sukumar >> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; Kamat, Nishant >> Subject: Re: [PATCH] omap3: nand: bch ecc support added >> >> Hi Ghorai, >> >> I am the initial author of this patch. And I guess this patch still >> uses most of my work. > [Ghorai] I know you are working on it, > > But I think your code was in a shape for - > 1. not for up-streamble shape That's because I never posted it for up-stream. > 2. non functional, No, it was a working (at least for 8-bit correction) patch on that kernel version (I do not remember the correct version now, may be .29-.30) It did not work for 4-bit, because of known reason. And I guess while posting this patch you should also have mentioned/documented about that. No? > So can you check this version matching with your original code? > In that case I can add your Signed-off. Yes, you should. I can see this version has got many changes, but original idea is same. And not all code is changed. Does it? Regards, Vimal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html