On Thu, Jan 20, 2011 at 03:29:50PM +0100, John Ogness wrote: > On 2011-01-20, Felipe Balbi <balbi@xxxxxx> wrote: > > scripts/get_maintainer.pl would've helped you getting a better Cc > > list. I'm adding linux-omap and lakml > > Thanks. > > After investigating the issue further it seems that I had it > backwards. The value of "n" is the value to divide by, not the value > that goes in the register. This means that it is _dpll_test_fint() > that is doing it incorrectly. Here is a new version of the patch to > fix the right function. you might want to look at Documentation/SubmittingPatches before sending these patches. If anyone applies this patch of yours the commitlog will have all the comments you've made above. Generally, patches are "standalone" emails, without a discussion on them, if you want to add comments which aren't supposed to go into commit log, then do so after the tear line (---) and before the diff --git line; that way, git will know it must drop that part of the comments. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html