Re: [PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18 January 2011 06:00, Nicolas Pitre <nico@xxxxxxxxxxx> wrote:
> On Mon, 17 Jan 2011, Russell King - ARM Linux wrote:
>
>> Add additional instructions to our assembly bitops functions to ensure
>> that they only operate on word-aligned pointers. ÂThis will be necessary
>> when we switch these operations to use the word-based exclusive
>> operations.
>>
>> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
>
> This breaks the Thumb2 kernel build:
>
> ÂAS Â Â Âarch/arm/lib/changebit.o
> arch/arm/lib/changebit.S: Assembler messages:
> arch/arm/lib/changebit.S:16: Error: Thumb does not support negative register indexing -- `strne r1,[r1,-r1]'
>
> I also wonder what happens with a misaligned ldrex/strex... Does the
> alignment trap get invoked?

According to the ARM ARM, unaligned ldrex/strex should generate an
alignment fault on ARMv6 (with SCTLR.U bit set) and ARMv7.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux