Re: Open issues after 2.6.38 merge window

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 17 Jan 2011, Russell King wrote:

> On Mon, Jan 17, 2011 at 01:31:47PM -0700, Paul Walmsley wrote:
> > 
> > OMAP15xx uses the MPU timer for its clocksource, since OMAP15xx doesn't 
> > have GPTIMERs or the 32k sync timer, and the MPU timer code in 
> > mach-omap1/time.c wasn't updated for sched_clock() support.
> > 
> > Adding an init_fixed_sched_clock() into omap_init_clocksource() should 
> > fix the boot on OMAP15xx/7xx.
> 
> No, it needs fixing properly.  There's no reason the gpt clocksource
> can't be used for sched_clock.

There's a very good reason why it can't on OMAP15xx/7xx.  GPTIMER/DMTIMER 
IP blocks are only present on OMAP1610 and later[1].  Nor is a 
SYNCTIMER_32K IP block present on OMAP15xx/7xx[2].

That said, the clocksource code in the OMAP tree could definitely use some 
cleanup.  The SYNCTIMER_32K/counter_32k clocksource should be registered 
from the plat-omap/counter_32k.c.  And your point about the compile-time 
negative dependencies is also a good one, now that omap1_defconfig exists.


- Paul

1. Current mainline source code for arch/arm/plat-omap/dmtimer.c, line 
   168:
   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/plat-omap/dmtimer.c;h=1d706cf63ca0e697521d38ab814d9889a1b70435;hb=refs/heads/master#l168

2. Current mainline source code for arch/arm/plat-omap/counter_32k.c, line 
   39:
   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/plat-omap/counter_32k.c;h=ea4644021fb9c0867c2e4ca4bd4bcb118e863f80;hb=refs/heads/master#l39

3. ibid.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux