On Mon, 2011-01-17 at 15:11 +0100, Thomas Weber wrote:
> The reset_gpio pin for lcd is connected with TWL4030 LedA.
> TWL4030 GPIO.1 has a not connected resistor.
>
> Fix indention issue. The comment line uses 8 whitespaces.
> Replaced with one tabulator.
>
> Reported-by: Daniel Morsing <daniel.morsing@xxxxxxxxx>
> Signed-off-by: Thomas Weber <weber@xxxxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/board-devkit8000.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c
> index 451e7ff..719f4e5 100644
> --- a/arch/arm/mach-omap2/board-devkit8000.c
> +++ b/arch/arm/mach-omap2/board-devkit8000.c
> @@ -114,9 +114,6 @@ static struct omap2_hsmmc_info mmc[] = {
>
> static int devkit8000_panel_enable_lcd(struct omap_dss_device *dssdev)
> {
> - twl_i2c_write_u8(TWL4030_MODULE_GPIO, 0x80, REG_GPIODATADIR1);
> - twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0);
> -
> if (gpio_is_valid(dssdev->reset_gpio))
> gpio_set_value_cansleep(dssdev->reset_gpio, 1);
> return 0;
> @@ -245,8 +242,8 @@ static int devkit8000_twl_gpio_setup(struct device *dev,
> /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
> gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
>
> - /* gpio + 1 is "LCD_PWREN" (out, active high) */
> - devkit8000_lcd_device.reset_gpio = gpio + 1;
> + /* TWL4030_GPIO_MAX + 0 is "LCD_PWREN" (out, active high) */
> + devkit8000_lcd_device.reset_gpio = gpio + TWL4030_GPIO_MAX + 0;
> gpio_request(devkit8000_lcd_device.reset_gpio, "LCD_PWREN");
> /* Disable until needed */
> gpio_direction_output(devkit8000_lcd_device.reset_gpio, 0);
Hey Thomas.
Only real issue I can see is that fact that the commit message doesn't
mention the removal of the low level twl4030 calls. They are essentially
non-functional in their current state and mentioning that and why they
were removed would help in any future code archaeology.
Regards,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
