Aaro Koskinen had written, on 01/10/2011 06:51 AM, the following: [..]
Thanks for pointing this out. Funny why it is in include/asm-generic/gpio.h instead of in include/linux/gpio.h considering it implemented in drivers/gpio/gpiolib.c :(+ if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) { + gpio_request(gpio + 1, "nDVI_PWR_EN"); + gpio_direction_output(gpio + 1, 0); + gpio_request(gpio + 2, "DVI_LDO_EN"); + gpio_direction_output(gpio + 2, 1);FYI, gpiolib provides gpio_request_one() and gpio_request_array() calls which make code simpler. I think any new code should use those _and_ do proper error checking.
Am I right in understanding that you are mentioning about DVI gpios alone? in that case, the LDO gpio is used for other functions as well in addition to driving DVI. I suppose we dont want to loose that function because dvi pwr_en gpio failed.
-- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
