On 01/06/11 13:16, Andrew Morton wrote: > On Thu, 6 Jan 2011 13:08:56 -0800 > Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote: > >> On Thu, 6 Jan 2011 13:04:40 -0800 Andrew Morton wrote: >> >>> On Thu, 9 Dec 2010 14:41:50 +0100 >>> Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> wrote: >>> >>>> +static DEVICE_ATTR(invert, 0644, bl_trig_invert_show, bl_trig_invert_store); >>> >>> This new sysfs file should be documented. Where would be an >>> appropriate place for that? Documentation/leds-class.txt doesn't >>> mention a sysfs API at all. >>> -- >> >> in Documentation/ABI/, where all sysfs interface info lives. >> > > Spose so. Documentation/ABI/stable/sysfs-class-backlight does have > some stuff in it. > > Personally I tend to regard Documentation/ABI/ as fairly useless > incomprehensible stuff, maintained to keep Greg happy ;) It'd be better > to have a nice little well-maintained document for a subsystem such as > this which actually explains its operation in a useful-to-humans way. > Rather than just mechanically filling out forms. > > But a Documentation/ABI update is a heck of a lot better than nothing. Yes, I was giving you the "where it currently lives", not "what is best." I agree with you. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html