On Wed, Jan 05, 2011 at 07:56:13AM -0600, Lambert, David wrote: > On Tue, Dec 28, 2010 at 8:18 AM, Mark Brown > > A comment explaining why we don't actually do anything with the request > > would be helpful. Given that we're ignoring the event it'd seem better > > to just leave it masked and not take the interrupt in the first place. > Since the IRQ handler isn't really doing anything in this driver, > would it better > to just not have one? Possibly, if the hardware doesn't care. > >> + dmic->clk_freq = freq; > >> + break; > >> + default: > >> + dev_err(dai->dev, "clk freq not supported %d\n", freq); > >> + ret = -EINVAL; > >> + goto err_freq; > >> + } > > Can't you ask the parent clock what rate it's set to? > Didn't really think there was a need for that on the audio driver. > There are clock API's available > to query that already. That's my point - you're requiring that the user pass in the rate rather than querying the clock API. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
