Kevin, On Wed, Jan 5, 2011 at 04:47, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Kevin Hilman <khilman@xxxxxx> [110104 14:45]: >> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote: >> > Mika Westerberg <ext-mika.1.westerberg@xxxxxxxxx> writes: >> > >> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of >> > > updating reg and l values. However, at the end of the function we >> > > perform a write: >> > > >> > > __raw_writel(l, reg); >> > > >> > > So on OMAP2+ we end up writing 0 to the bank->base which is not >> > > correct (typically this points to GPIO_REVISION register). >> > > >> > > Fix this by returning immediately after call to >> > > set_24xx_gpio_triggering(). >> > > >> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@xxxxxxxxx> >> > >> > Acked-by: Kevin Hilman <khilman@xxxxxx> >> > >> > Tony, this should be added to omap-for-linus as it fixes a problem in >> > the recently merged GPIO omap_device/hwmod conversion. One clarification - This problem should be existing since the following commit 92105bb70634abacc08bbe12bf6f888fbd7dad38 which was introduced on Sep 7, 2005 FYI, this part of the code remained untouched during GPIO omap_device/hwmod conversion. -V Charulatha >> >> On second thought, it's a bit late for the main 2.6.38 window, so will >> queue this in my pm-fixes branch for the .38-rc cycle. > > Yeah let's not mess with omap-for-linus right now, but instead start > queueing up fixes for -rc1. > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
