* Guruswamy Senthilvadivu <svadivu@xxxxxx> [110103 04:51]: > + char *omap2_oh_name[] = { "dss_dss", "dss_dispc", "dss_rfbi", > + "dss_venc" }; > + char *omap3_oh_name[] = { "dss_dss", "dss_dispc", "dss_rfbi", > + "dss_venc", "dss_dsi1" }; > + char *omap2_dev_name[] = { "omap_dss", "omap_dispc", "omap_rfbi", > + "omap_venc" }; > + char *omap3_dev_name[] = { "omap_dss", "omap_dispc", "omap_rfbi", > + "omap_venc", "omap_dsi1" }; > + char *(*oh_name)[]; > + char *(*dev_name)[]; > + int oh_count; > + > + if (cpu_is_omap24xx()) { > + oh_name = &omap2_oh_name; > + dev_name = &omap2_dev_name; > + oh_count = ARRAY_SIZE(omap2_oh_name); > + } else { > + oh_name = &omap3_oh_name; > + dev_name = &omap3_dev_name; > + oh_count = ARRAY_SIZE(omap3_oh_name); > + } Here it looks like you don't need to repeat the common names "dss_dss", "dss_dispc", "dss_rfbi". Instead you can have a common char *omap_oh_name[5] then set oh_count smaller based on the omap type. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html