>>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>Sent: Thursday, December 23, 2010 2:01 AM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; >>paul@xxxxxxxxx; Cousson, Benoit; Sripathy, Vishwanath; Sawant, Anand; >>Menon, Nishanth >>Subject: Re: [PATCH v6 07/10] OMAP3: PM: Adding T2 enabling of smartreflex >>support >> >>Hi Thara, >> >>Thara Gopinath <thara@xxxxxx> writes: >> >>> This patch adds support in the twl4030 driver to enable smartreflex. >>> The smartreflex bit on twl4030 needs to be enabled by default >>irrespective >>> of whether smartreflex module is enabled on the OMAP side or not. >>> This is because without this bit enabled the voltage scaling through >>> vp forceupdate does not function properly. >> >>Is this true for OMAP2 as well? >> >>This patch actually hangs the boot on 2430SDP. Hello Kevin, I tried the latest lo master with smartreflex module compiled in using omap2plus_defconfig and this patch on OMAP2430 SDP and it boots fine for me. Your pm-core branch does not boot for me with or without this patch on OMAP2430 SDP. But then I am not sure if this is needed for OMAP2 also. Considering this might be a omap and twl4030 dependent setting, my idea is to move this code to mach-omap2/omap_twl.c. I will post a patch for the same shortly. Regards Thara -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html