Kishon,
On Tue, Dec 21, 2010 at 13:10, Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
> Implement McBSP as platform device and add support for
> registering through platform device layer using resource
> structures.
>
> Later in this patch series, OMAP2+ McBSP driver would be modified to
> use hwmod framework after populating the omap2+ hwmod database.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> arch/arm/mach-omap1/mcbsp.c | 383 ++++++++++++++---
> arch/arm/mach-omap2/mcbsp.c | 708 +++++++++++++++++++++++++------
> arch/arm/plat-omap/devices.c | 10 +-
> arch/arm/plat-omap/include/plat/mcbsp.h | 14 +-
> arch/arm/plat-omap/mcbsp.c | 60 +++-
> 5 files changed, 969 insertions(+), 206 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/mcbsp.c b/arch/arm/mach-omap1/mcbsp.c
> index 372ea71..4324ba4 100644
> --- a/arch/arm/mach-omap1/mcbsp.c
> +++ b/arch/arm/mach-omap1/mcbsp.c
> @@ -10,6 +10,7 @@
> *
> * Multichannel mode not supported.
> */
> +#include <linux/ioport.h>
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/clk.h>
> @@ -78,114 +79,354 @@ static struct omap_mcbsp_ops omap1_mcbsp_ops = {
> };
>
> #if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
> +struct resource omap7xx_mcbsp_res[][6] = {
> + {
> + {
> + .name = "mpu",
> + .start = OMAP7XX_MCBSP1_BASE,
> + .end = OMAP7XX_MCBSP1_BASE + SZ_256,
> + .flags = IORESOURCE_MEM,
> + },
> + {
> + .name = "dma",
> + .start = OMAP7XX_MCBSP1_BASE,
> + .end = OMAP7XX_MCBSP1_BASE + SZ_256,
> + .flags = IORESOURCE_MEM,
> + },
The above two resources looks similar except for the name. It would be
good to mention the reason for
providing two resource names for a single resource.
Same comment applicable to all McBSPs in other OMAPs too.
-V Charulatha
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
