* Sutharsan R <sutharsan.ram@xxxxxxxxx> [101220 18:41]: > This patch adds and exports gpmc configuration functions. > 'gpmc' configuration functions will be used by > westbridge device controller driver in staging tree. > This patch is part of the work to get westbridge device controller driver > out of staging tree. Looks good in general.. > +EXPORT_SYMBOL(cywb_pnand_platform_retime); But this you should not need. I know tusb6010 is still doing that, but you can pass it in the platform_data and then there's no need to export it. Then in your driver you can do: if (xxxxx->retime) xxxxx->retime(123); That way the driver will stay generic. The set_power functions are doing that in drivers/usb/musb if you need examples. Also, this will need a slight update based on Adrian Hunter's patch "OMAP2/3: GPMC: put sync_clk value in picoseconds instead of nanosecond" that I'll be queuing. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
