Hi, linux-omap-owner@xxxxxxxxxxxxxxx wrote: > Hi, > > On Mon, 2010-11-29 at 17:21 +0530, ext Guruswamy Senthilvadivu wrote: >> From: Senthilvadivu Guruswamy <svadivu@xxxxxx> >> >> Database generated for Display Sub System applicable for >> OMAP3430-ES2 onwards and OMAP36xx. >> dss is also considered as an IP as dispc,rfbi, and named as dss_dss. >> For all the IP modules in DSS, same clock is needed for enabling. >> hwmod sees as independent IPs, so same clock has to be repeated as .mainclk >> in each IP. OMAP3430ES1 do not have IDLEST bit to poll on for dss IP. So >> this hwmod is not applicable for 3430ES1. > > I'm not so familiar with hwmods, so I cannot comment much on > the first three patches in this series. I'll continue going > through the latter patches. > > One question though: what does the mainclk do? If it means "a > clock which enables access to the registers", I'm not sure > it's entirely correct. The DSS clocking can be changed to get > the functional clock from DSI PLL. On OMAP4 there are MODULEMODE bits for DSS and other domains, these need to be enabled to use the module, I think that's what mainclk represents here. You can have a look at the CM_DSS_DSS_CLKCTRL register in the OMAP4 TRM to get a better idea. So, instead of explicitly enabling/disabling the interface clocks like we did for DSS in omap3, we just need to ensure that MODULEMODE bits are set, setting this will take care of enabling/gating interface clocks based on the state of the clock domain. I think we consider the DSS1_ALWAYSON_FCK as the mainclk. Others, please correct me if I am wrong. Regards, Archit > > Then a general comment about all the patches in the series: > The commit descriptions do not seem to be of very high > quality. They are short and poorly formatted. The > descriptions are almost as important as the patch itself. > > Here's a nice text about commit messages: > http://who-t.blogspot.com/2009/12/on-commit-messages.html > > And some comments of my own: > - Use capital letters for DSS, DISPC, etc. when not > spesifically referring to some variable or similar. > - Use space after comma. > - Wrap the lines consistently. Now it looks like the lines > are wrapped at random points in some commits. > - Use an empty line between paragraphs > - While I understand that you (me neither) are not native > english speaker, try to spend some time to be sure that there > are no errors due to carelessness. > - Remember that the 00 patch is not saved in git, so it > should only be an intro, and all the relevant information > should be found in the actual commit messages. > > Tomi-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
