Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tony Lindgren had written, on 12/17/2010 12:02 PM, the following:
* Menon, Nishanth <nm@xxxxxx> [101217 09:50]:
On Wed, Dec 8, 2010 at 10:49, David Anders <x0132446@xxxxxx> wrote:
On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote:
The .gpio_cd member of omap2_hsmmc_info is not initialized. This
will default to zero. On Pandaboard this interferes with gpio line
assigned for powering TFP410 DVI chip.

This fix was missed out in the previous commit bf56f0a6668cd, from
Nishanth Menon

Signed-off-by: Kishore Kadiyala<kishore.kadiyala@xxxxxx>
Signed-off-by: Raghuveer Murthy<raghuveer.murthy@xxxxxx>
Acked-by: Nishanth Menon<nm@xxxxxx>

Tested-by: David Anders <x0132446@xxxxxx>
Tony,
this is a regression introduced in my commit for .37-rc1. any chance
of this making to one of 37 rc cycles? I can re-post this patch
including l-a if that is the path you'd like.

Yes please, and also explain what exactly this breaks.

If it just breaks MMC card detect with some DVI chip driver that's
not merged yet, then this would be in the "it never worked before".
The regression is card detect ends up refering to a valid GPIO -> yeah as a result the upcoming DVI driver is broken without this patch. given that commit bf56f0a6668cd was intended to fix cd, it did not do it cleanly - hence my claim of regression. DVI in opinion is just a symptom of the wiring of GPIO0 on the board.

ok with considering this a regression?

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux