Hello. On 16-12-2010 18:25, srinath@xxxxxxxxxxxxxxxxxxxx wrote:
From: Srinath <srinath@xxxxxxxxxxxxxxxxxxxx>
AM3517/05 Craneboard has one EHCI interface on board using port1.
GPIO35 is used as power enable. GPIO38 is used as port1 PHY reset.
History: http://marc.info/?l=linux-omap&w=2&r=1&s=Craneboard%3A+Add+USB+EHCI+support&q=t
Signed-off-by: Srinath <srinath@xxxxxxxxxxxxxxxxxxxx> --- arch/arm/mach-omap2/board-am3517crane.c | 53 +++++++++++++++++++++++++++++++ 1 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c index 8ba4047..1a80175 100644 --- a/arch/arm/mach-omap2/board-am3517crane.c +++ b/arch/arm/mach-omap2/board-am3517crane.c
[...]
@@ -51,10 +58,56 @@ static void __init am3517_crane_init_irq(void)
[...]
static void __init am3517_crane_init(void) { + int ret; + omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); omap_serial_init(); + + /* Configure GPIO for EHCI port */ + if (omap_mux_init_gpio(GPIO_USB_NRESET, OMAP_PIN_OUTPUT)) { + pr_err("Can not cofigure mux for GPIO_USB_NRESET %d\n", + GPIO_USB_NRESET); + return; + } + + if (omap_mux_init_gpio(GPIO_USB_POWER, OMAP_PIN_OUTPUT)) { + pr_err("Can not cofigure mux for GPIO_USB_POWER %d\n", +
Empty line not needed here...
+ GPIO_USB_POWER); + return; + } + + ret = gpio_request(GPIO_USB_POWER, "usb_ehci_enable"); + if (ret < 0) { + pr_err("Cannot request GPIO %d\n", GPIO_USB_POWER); + return; + } + + ret = gpio_direction_output(GPIO_USB_POWER, 1); + if (ret < 0) + goto err; + +
Too many empty lines here...
+ usb_ehci_init(&ehci_pdata); + return; + +err:
There's no need for *goto* and label.
+ gpio_free(GPIO_USB_POWER); + pr_err("Unable to initialize EHCI power\n"); + return; }
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html