On Thu, Dec 16, 2010 at 11:01 AM, Ramirez Luna, Omar <omar.ramirez@xxxxxx> wrote: > Hi, > > On Thu, Dec 16, 2010 at 10:32 AM, Kanigeri, Hari <h-kanigeri2@xxxxxx> wrote: >>> @@ -130,12 +120,6 @@ static int omap2_mbox_startup(struct omap_mbox *mbox) >>> l = mbox_read_reg(MAILBOX_REVISION); >>> pr_debug("omap mailbox rev %d.%d\n", (l & 0xf0) >> 4, (l & 0x0f)); >>> >>> - if (cpu_is_omap44xx()) >>> - l = OMAP4_SMARTIDLE; >>> - else >>> - l = SMARTIDLE | AUTOIDLE; >>> - mbox_write_reg(l, MAILBOX_SYSCONFIG); >>> - >> >> The OMAP4 mailbox sysconfig register bits are laid out differently >> from previous OMAP mailbox's. Example is smart idle bit location is >> different from previous OMAPs. Can I know as how are you handling this >> aspect in hwmod code ? > > hwmod framework provides definition for both IP models > (omap_hwmod_sysc_type1for omap2/3 or omap_hwmod_sysc_type2 for omap4), > these are located at arch/arm/mach-omap2/omap_hwmod_common_data.c > Thanks, Omar. Best regards, Hari Kanigeri -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html