Re: [PATCH v3] OMAP3: clean up ASM idle code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

* jean.pihet@xxxxxxxxxxxxxx <jean.pihet@xxxxxxxxxxxxxx> [101214 09:28]:
> From: Jean Pihet <j-pihet@xxxxxx>
> 
> This patch only contains clean-ups and cosmetic changes,
> no functional change.
> 
> Clean up of the ASM code:
> - reorganized the code in logical sections: defines, API
>    functions, internal functions and variables,
> - reworked and simplified the execution paths, for better
>    readability and to avoid duplication of code,
> - added comments on the entry and exit points and the interaction
>    with the ROM code for OFF mode restore,
> - reworked the existing comments for better readability,
> - reworked the code formating, alignment and white spaces,
> - added comments for the i443 erratum workarounds,
> - changed the hardcoded values in favor of existing macros
>    from include files,
> - clean up of non used symbols.

Can you please split it further, it's not obvious from reading it
that it does not change anything.

How about first do one or more patches to move the code around.
Then rework the comments and formatting.

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux